Commit 01ccbb8c authored by thomas.forbriger's avatar thomas.forbriger

issue25 [CLOSE]: all tasks completed

- all tasks completed with commit d6f5641a
- definition of time correction cannot be resolved uniquely with available data
parent 08a210b8
this is <issue25-libdatrwxx-miniseed-consistency-checks.txt>
============================================================================
libdatrwxx: MiniSEED consistency checks
---------------------------------------
Final note:
Without data which would use the time correction field in the Fixed
Section of Data Header I cannot test the mechnism for consistency.
The SEED Manual itself is not fully conclusive in this respect:
On page 108 of "SEED Reference Manual, Standard for the Exchange of Earthquake
Data, SEED Format Version 2.4, August, 2012":
note 16: LONG: Time correction. This field contains a value that may modify
the field 8 record start time. Depending on the setting of bit 1 in field
12, the record start time may have already been adjusted. The units are in
0.0001 seconds.
The correction field accordingly may carry a sign. It is implemented in
datrw::mseed::SEED::FixedDataRecordHeader as "int tcorr". It is applied
accordingly in libtime::TAbsoluteTime datrw::mseed::MiniSEEDRecord::date()
The SEED Manual misses to define whether the correction should be added or
subtracted.
----------------------------------------------------------------------------
As a reminder:
- check application of time correction before finishing this issue
time correction is not part of this issue, however Chad Trabant has made a
respective note in libmseed - I like to make sure that libdatrwxx does it
correctly
There indeed was a bug in datrw::mseed::SEED::DataExtensionBlockette
The mircoseconds field by definition can carry a sign (i.e. it may be
negative). It was evaluated as a non-negative quantity. This is fixed with
commit e74998e9891 and a corresponding consistency check is introduced with
commit 0d001823965
Non of my current test data uses the time correction field in the Fixed
Section of Data Header. Application of this correction therefor cannot be
tested.
The comment by Chad Trabant mentioned above does not address reading of
MiniSEED data (IMHO) but addresses proper splitting and round-off of time
values when writing data. This currently is of no concern for libdatrwxx.
----- END OF issue25-libdatrwxx-miniseed-consistency-checks.txt -----
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment