Comment out the firewalld dependent tasks for Fedora28

Fedora 28 does not provide python2-firewalld which is needed by the
ansible module firewalld. Therefore these roles would fail. See issue #28 for this

This is not a fix, but a dirty hack to let the other tasks complete

roles/common/tasks/sshd.yml

@@ -10,8 +10,13 @@
   package:
     name: python-firewall
     state: present
-  when: ansible_distribution == "Fedora" or
-        (ansible_distribution == "CentOS" and ansible_distribution_major_version >= 7)
+  when: ((ansible_distribution == "Fedora" and ansible_distribution_major_version < 28) or
+         (ansible_distribution == "CentOS" and ansible_distribution_major_version >= 7))
+
+- name: Warn about firewalld not working
+  debug:
+    msg: Because python3-firewall is not working with the firewalld module, this tasks will not work!
+  when: (ansible_distribution == "Fedora" and ansible_distribution_major_version >= 28)
 
 - name: Open port 22 on Fedora/CentOS
   become: yes
@@ -19,8 +24,8 @@
     port: 22/tcp
     state: enabled
     permanent: true
-  when: ansible_distribution == "Fedora" or
-        (ansible_distribution == "CentOS" and ansible_distribution_major_version >= 7)
+  when: ((ansible_distribution == "Fedora" and ansible_distribution_major_version < 28) or
+         (ansible_distribution == "CentOS" and ansible_distribution_major_version >= 7))
   notify:
     - reload firewalld
     - restart firewalld

roles/nfs-server/tasks/nfsd.yml

 ---
 # https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux
+- name: install dependencies for Fedora >= 28
+  dnf:
+    state: present
+    name: "{{ item }}"
+  with_items:
+  - rpcbind
+  - python3-firewall
+  when: (ansible_distribution == 'Fedora' and ansible_distribution_major_version >= 28)
+
 - name: install dependencies
   dnf:
     state: present
@@ -7,6 +16,7 @@
   with_items:
   - rpcbind
   - python-firewall
+  when: (ansible_distribution == 'Fedora' and ansible_distribution_major_version < 28)
 
 - name: copy export file
   copy:
@@ -20,6 +30,7 @@
   - enable nfsd
   - reload nfsd
 
+# currently firewalld is not working for Fedora 28 (see iss. #28)
 - name: set firewall
   firewalld:
     port: "{{ item }}"
@@ -29,4 +40,4 @@
   - 2049/tcp
   - 111/tcp
   notify: reload firewall
-
+  when: (ansible_distribution == 'Fedora' and ansible_distribution_major_version < 28)