From b93fa0a339d74ce657e6d8a152bfe94a1e14609c Mon Sep 17 00:00:00 2001
From: Julian Gethmann <julian.gethmann@kit.edu>
Date: Mon, 5 Feb 2018 18:46:49 +0100
Subject: [PATCH] clean up pelegant_setup.sh code

---
 roles/elegant/files/pelegant_setup.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/roles/elegant/files/pelegant_setup.sh b/roles/elegant/files/pelegant_setup.sh
index 429cda9..48a9b93 100755
--- a/roles/elegant/files/pelegant_setup.sh
+++ b/roles/elegant/files/pelegant_setup.sh
@@ -29,21 +29,21 @@ if [ -f ~/.mpihosts ]; then
   /usr/bin/mv ~/.mpihosts ~/.mpihosts.$(date --iso)
 fi
 for host in "${!host_cpus[@]}"; do
-  /usr/bin/echo "${host}:${host_cpus[$host]}" user=${USER} >> ~/.mpihosts
+  printf "%s:%s user=%s\n", "${host}" "${host_cpus[$host]}" "${USER}" >> ~/.mpihosts
 done
 
 printf "Copying files and mounting SSHFS\n"
 for host in "${!host_cpus[@]}"; do
-  cpu="${host_cpus[$host]}"
-  printf "SSH copy from %s to %s (%s)", ${main_host}, ${host}, ${filename}
+  printf "SSH copy from %s to %s (%s)", "${main_host}" "${host}" "${filename}"
   scp "${filename}" "${host}:~/.ssh/"
   scp "${filename}.pub" "${host}:~/.ssh/"
-  ssh-copy-id -i "${filename}" ${host}
-  ssh-copy-id -i "${filename}" ${main_host}
+  ssh-copy-id -i "${filename}" "${host}"
+  ssh-copy-id -i "${filename}" "${main_host}"
 
   scp ~/.mpihosts "${host}:.mpihosts"
 
   curdir=${PWD}
-  ssh -i "${filename}" ${host} "ssh-copy-id -i ${filename} ${main_host}"
-  ssh -i "${filename}" ${host} "mkdir ${curdir} && sshfs ${main_host}:${curdir} ${curdir} -o IdentityFile=\"${filename}\""
+  ssh -i "${filename}" "${host}"\
+	  "mkdir ${curdir} && "\
+	  "sshfs ${main_host}:${curdir} ${curdir} -o IdentityFile=\"${filename}\""
 done
-- 
GitLab