Fix int issue

roles/clients/tasks/cups.yml

@@ -9,11 +9,8 @@
 - name: install dependencies
   become: yes
   dnf:
-    name: "{{ item }}"
+    name: ["hplip-common", "hplip"]
     state: present
-  with_items:
-    - "hplip-common"
-    - "hplip"
   when: ansible_distribution == 'Fedora'
 
 - name: install CUPS

roles/common/tasks/etckeeper.yml

@@ -20,7 +20,7 @@
     line: "HIGHLEVEL_PACKAGE_MANAGER=dnf"
     regexp: "HIGHLEVEL_PACKAGE_MANAGER=.*"
     backup: yes
-  when: (ansible_distribution == "Fedora" and (ansible_distribution_major_version|int) >= "18")
+  when: (ansible_distribution == "Fedora" and (ansible_distribution_major_version|int) >= 18)
 
 - name: yum as package manager
   become: yes
@@ -29,7 +29,7 @@
     line: "HIGHLEVEL_PACKAGE_MANAGER=yum"
     regexp: "HIGHLEVEL_PACKAGE_MANAGER=.*"
     backup: yes
-  when: (ansible_distribution == "CentOS" and (ansible_distribution_major_version|int) <= "7")
+  when: (ansible_distribution == "CentOS" and (ansible_distribution_major_version|int) <= 7)
 
 - name: apt as package manager
   lineinfile:

roles/common/tasks/sshd.yml

@@ -10,8 +10,8 @@
   package:
     name: python-firewall
     state: present
-  when: ((ansible_distribution == "Fedora" and (ansible_distribution_major_version|int) < 28)) or
-         (ansible_distribution == "CentOS" and (ansible_distribution_major_version|int) >= 7)))
+  when: ((ansible_distribution == "Fedora" and (ansible_distribution_major_version|int) < 28) or
+         (ansible_distribution == "CentOS" and (ansible_distribution_major_version|int) >= 7))
 
 - name: Warn about firewalld not working
   debug:

sites.yml

 ---
 - vars:
   ansible_python_interpreter: "/usr/bin/env python3"
-  when: (ansible_distribution == 'Fedora' and ansible_distribution_version >= 28)
+  when: (ansible_distribution == 'Fedora' and (ansible_distribution_version|int) >= 28)
 
 - import_playbook: common.yml
 - import_playbook: clients.yml