beverify.c 26.2 KB
Newer Older
Christian Würdig's avatar
Christian Würdig committed
1
/*
Michael Beck's avatar
Michael Beck committed
2
 * Copyright (C) 1995-2008 University of Karlsruhe.  All right reserved.
Christian Würdig's avatar
Christian Würdig committed
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
 *
 * This file is part of libFirm.
 *
 * This file may be distributed and/or modified under the terms of the
 * GNU General Public License version 2 as published by the Free Software
 * Foundation and appearing in the file LICENSE.GPL included in the
 * packaging of this file.
 *
 * Licensees holding valid libFirm Professional Edition licenses may use
 * this file in accordance with the libFirm Commercial License.
 * Agreement provided with the Software.
 *
 * This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 * WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 * PURPOSE.
 */

Christian Würdig's avatar
Christian Würdig committed
20
21
22
23
24
25
/**
 * @file
 * @brief       Various verify routines that check a scheduled graph for correctness.
 * @author      Matthias Braun
 * @date        05.05.2006
 * @version     $Id$
26
 */
27
#include "config.h"
28

29
30
#include <limits.h>

31
32
33
#include "bitset.h"
#include "set.h"
#include "array.h"
34
35
36
37
38
39

#include "irnode.h"
#include "irgraph.h"
#include "irgwalk.h"
#include "irprintf.h"
#include "irdump_t.h"
40
#include "iredges.h"
41
42
43
44

#include "beverify.h"
#include "belive.h"
#include "besched_t.h"
45
#include "benode_t.h"
46
#include "beirg_t.h"
47
#include "beintlive_t.h"
48

49
50
static int my_values_interfere(const ir_node *a, const ir_node *b);

51
typedef struct be_verify_register_pressure_env_t_ {
Christian Würdig's avatar
Christian Würdig committed
52
	ir_graph                    *irg;                 /**< the irg to verify */
Sebastian Hack's avatar
Sebastian Hack committed
53
	 be_lv_t                    *lv;                  /**< Liveness information. */
Christian Würdig's avatar
Christian Würdig committed
54
55
56
	const arch_register_class_t *cls;                 /**< the register class to check for */
	int                         registers_available;  /**< number of available registers */
	int                         problem_found;        /**< flag indicating if a problem was found */
57
58
} be_verify_register_pressure_env_t;

Christian Würdig's avatar
Christian Würdig committed
59
60
61
/**
 * Print all nodes of a pset into a file.
 */
62
63
static void print_living_values(FILE *F, const ir_nodeset_t *live_nodes) {
	ir_nodeset_iterator_t iter;
64
65
	ir_node *node;

Christian Würdig's avatar
Christian Würdig committed
66
	ir_fprintf(F, "\t");
67
	foreach_ir_nodeset(live_nodes, node, iter) {
Christian Würdig's avatar
Christian Würdig committed
68
		ir_fprintf(F, "%+F ", node);
69
	}
Christian Würdig's avatar
Christian Würdig committed
70
	ir_fprintf(F, "\n");
71
72
}

Christian Würdig's avatar
Christian Würdig committed
73
74
75
/**
 * Check if number of live nodes never exceeds the number of available registers.
 */
76
static void verify_liveness_walker(ir_node *block, void *data) {
Christian Würdig's avatar
Christian Würdig committed
77
	be_verify_register_pressure_env_t *env = (be_verify_register_pressure_env_t *)data;
78
	ir_nodeset_t live_nodes;
79
	ir_node *irn;
80
	int pressure;
81

Christian Würdig's avatar
Christian Würdig committed
82
	/* collect register pressure info, start with end of a block */
Sebastian Hack's avatar
Sebastian Hack committed
83
	// ir_fprintf(stderr, "liveness check %+F\n", block);
84
	ir_nodeset_init(&live_nodes);
85
	be_liveness_end_of_block(env->lv, env->cls, block,
86
	                         &live_nodes);
Christian Würdig's avatar
Christian Würdig committed
87

Sebastian Hack's avatar
Sebastian Hack committed
88
	// print_living_values(stderr, &live_nodes);
89
	pressure = ir_nodeset_size(&live_nodes);
90
91
92
	if(pressure > env->registers_available) {
		ir_fprintf(stderr, "Verify Warning: Register pressure too high at end of block %+F(%s) (%d/%d):\n",
			block, get_irg_dump_name(env->irg), pressure, env->registers_available);
93
		print_living_values(stderr, &live_nodes);
94
95
		env->problem_found = 1;
	}
96

97
	sched_foreach_reverse(block, irn) {
Christian Würdig's avatar
Christian Würdig committed
98
		if (is_Phi(irn))
99
100
			break;

Sebastian Hack's avatar
Sebastian Hack committed
101
		// print_living_values(stderr, &live_nodes);
102
		be_liveness_transfer(env->cls, irn, &live_nodes);
103

104
		pressure = ir_nodeset_size(&live_nodes);
105

106
		if(pressure > env->registers_available) {
107
108
			ir_fprintf(stderr, "Verify Warning: Register pressure too high before node %+F in %+F(%s) (%d/%d):\n",
				irn, block, get_irg_dump_name(env->irg), pressure, env->registers_available);
109
			print_living_values(stderr, &live_nodes);
110
			env->problem_found = 1;
Sebastian Hack's avatar
Sebastian Hack committed
111
			assert(0);
112
113
		}
	}
114
	ir_nodeset_destroy(&live_nodes);
115
116
}

Christian Würdig's avatar
Christian Würdig committed
117
118
119
/**
 * Start a walk over the irg and check the register pressure.
 */
120
121
122
int be_verify_register_pressure(const be_irg_t *birg,
                                const arch_register_class_t *cls,
                                ir_graph *irg) {
123
124
	be_verify_register_pressure_env_t env;

Sebastian Hack's avatar
Sebastian Hack committed
125
	env.lv                  = be_liveness(birg);
Christian Würdig's avatar
Christian Würdig committed
126
127
	env.irg                 = irg;
	env.cls                 = cls;
Sebastian Hack's avatar
Sebastian Hack committed
128
	env.registers_available = env.cls->n_regs - be_put_ignore_regs(birg, env.cls, NULL);
Christian Würdig's avatar
Christian Würdig committed
129
	env.problem_found       = 0;
130

Sebastian Hack's avatar
Sebastian Hack committed
131
	be_liveness_assure_sets(env.lv);
Christian Würdig's avatar
Christian Würdig committed
132
	irg_block_walk_graph(irg, verify_liveness_walker, NULL, &env);
Sebastian Hack's avatar
Sebastian Hack committed
133
	be_liveness_free(env.lv);
Christian Würdig's avatar
Christian Würdig committed
134
135

	return ! env.problem_found;
136
137
}

138
139


140
/*--------------------------------------------------------------------------- */
141
142
143



144
typedef struct be_verify_schedule_env_t_ {
145
146
147
	int      problem_found;     /**< flags indicating if there was a problem */
	bitset_t *scheduled;        /**< bitset of scheduled nodes */
	ir_graph *irg;              /**< the irg to check */
148
149
} be_verify_schedule_env_t;

Christian Würdig's avatar
Christian Würdig committed
150
151
152
/**
 * Simple schedule checker.
 */
153
static void verify_schedule_walker(ir_node *block, void *data) {
154
	be_verify_schedule_env_t *env = (be_verify_schedule_env_t*) data;
155
	ir_node *node;
Matthias Braun's avatar
Matthias Braun committed
156
	ir_node *non_phi_found = NULL;
157
	int cfchange_found = 0;
158
	/* TODO ask arch about delay branches */
159
	int delay_branches = 0;
160
	int last_timestep = INT_MIN;
161
162

	/*
163
164
165
166
	 * Tests for the following things:
	 *   1. Make sure that all phi nodes are scheduled at the beginning of the block
	 *   2. There is 1 or no control flow changing node scheduled and exactly delay_branches operations after it.
	 *   3. No value is defined after it has been used
167
168
	 *   4. mode_T nodes have all projs scheduled behind them followed by Keeps
	 *       (except mode_X projs)
169
	 */
170
171
	sched_foreach(block, node) {
		int i, arity;
172
173
		int timestep;

174
		/* this node is scheduled */
175
176
177
178
179
180
		if(bitset_is_set(env->scheduled, get_irn_idx(node))) {
			ir_fprintf(stderr, "Verify warning: %+F appears to be schedule twice\n");
			env->problem_found = 1;
		}
		bitset_set(env->scheduled, get_irn_idx(node));

181
		/* Check that scheduled nodes are in the correct block */
182
183
184
185
186
		if(get_nodes_block(node) != block) {
			ir_fprintf(stderr, "Verify warning: %+F is in block %+F but scheduled in %+F\n", node, get_nodes_block(node), block);
			env->problem_found = 1;
		}

187
		/* Check that timesteps are increasing */
188
189
190
191
192
193
194
		timestep = sched_get_time_step(node);
		if(timestep <= last_timestep) {
			ir_fprintf(stderr, "Verify warning: Schedule timestep did not increase at node %+F\n",
			           node);
			env->problem_found = 1;
		}
		last_timestep = timestep;
195

196
		/* Check that phis come before any other node */
197
		if (is_Phi(node)) {
Matthias Braun's avatar
Matthias Braun committed
198
199
200
			if (non_phi_found != NULL) {
				ir_fprintf(stderr, "Verify Warning: Phi node %+F scheduled after non-Phi nodes (for example %+F) in block %+F (%s)\n",
					node, non_phi_found, block, get_irg_dump_name(env->irg));
201
202
				env->problem_found = 1;
			}
Matthias Braun's avatar
Matthias Braun committed
203
		} else {
Matthias Braun's avatar
Matthias Braun committed
204
			non_phi_found = node;
205
		}
206

207
		/* Check for control flow changing nodes */
208
		if (is_cfop(node) && get_irn_opcode(node) != iro_Start) {
Christian Würdig's avatar
Christian Würdig committed
209
210
211
			/* check, that only one CF operation is scheduled */
			if (cfchange_found == 1) {
				ir_fprintf(stderr, "Verify Warning: More than 1 control flow changing node (%+F) scheduled in block %+F (%s)\n",
212
					node, block, get_irg_dump_name(env->irg));
213
214
215
				env->problem_found = 1;
			}
			cfchange_found = 1;
Christian Würdig's avatar
Christian Würdig committed
216
		} else if (cfchange_found) {
217
			/* proj and keepany aren't real instructions... */
218
219
220
221
222
223
224
225
226
			if(!is_Proj(node) && !be_is_Keep(node)) {
				/* check for delay branches */
				if (delay_branches == 0) {
					ir_fprintf(stderr, "Verify Warning: Node %+F scheduled after control flow changing node (+delay branches) in block %+F (%s)\n",
						node, block, get_irg_dump_name(env->irg));
					env->problem_found = 1;
				} else {
					delay_branches--;
				}
227
228
			}
		}
229

230
		/* Check that all uses come before their definitions */
231
		if(!is_Phi(node)) {
232
			int nodetime = sched_get_time_step(node);
233
			for(i = 0, arity = get_irn_arity(node); i < arity; ++i) {
234
235
236
237
238
239
240
241
242
243
				ir_node *arg = get_irn_n(node, i);
				if(get_nodes_block(arg) != block
				   || !sched_is_scheduled(arg))
					continue;

				if(sched_get_time_step(arg) >= nodetime) {
					ir_fprintf(stderr, "Verify Warning: Value %+F used by %+F before it was defined in block %+F (%s)\n",
					           arg, node, block, get_irg_dump_name(env->irg));
					env->problem_found = 1;
				}
244
			}
245
		}
246

247
		/* Check that no dead nodes are scheduled */
248
249
250
251
252
		if(get_irn_n_edges(node) == 0) {
			ir_fprintf(stderr, "Verify warning: Node %+F is dead but scheduled in block %+F (%s)\n",
			           node, block, get_irg_dump_name(env->irg));
			env->problem_found = 1;
		}
253

Matthias Braun's avatar
Matthias Braun committed
254
		if(be_is_Keep(node)) {
255
256
257
258
259
			/* at least 1 of the keep arguments has to be it schedule
			 * predecessor */
			int      arity   = get_irn_arity(node);
			int      problem = 1;
			ir_node *prev    = sched_prev(node);
260
261
262
			while(be_is_Keep(prev))
				prev = sched_prev(prev);

Matthias Braun's avatar
Matthias Braun committed
263
264
			for(i = 0; i < arity; ++i) {
				ir_node *in = get_irn_n(node, i);
265
266
267
				in = skip_Proj(in);
				if(in == prev)
					problem = 0;
268
			}
Matthias Braun's avatar
Matthias Braun committed
269
			if(problem) {
Matthias Braun's avatar
Matthias Braun committed
270
				ir_fprintf(stderr, "%+F not scheduled after its pred node in block %+F (%s)\n",
Matthias Braun's avatar
Matthias Braun committed
271
272
				           node, block, get_irg_dump_name(env->irg));
				env->problem_found = 1;
273
274
			}
		}
275
276
	}

277
	/* check that all delay branches are filled (at least with NOPs) */
Christian Würdig's avatar
Christian Würdig committed
278
	if (cfchange_found && delay_branches != 0) {
279
		ir_fprintf(stderr, "Verify warning: Not all delay slots filled after jump (%d/%d) in block %+F (%s)\n",
280
			block, get_irg_dump_name(env->irg));
281
282
283
		env->problem_found = 1;
	}
}
284

285
286
static int should_be_scheduled(ir_node *node)
{
287
288
289
	if(is_Block(node))
		return -1;

290
291
292
	if(is_Proj(node))
		return 0;

293
	if(get_irn_mode(node) == mode_M) {
Michael Beck's avatar
Michael Beck committed
294
		if(is_Phi(node) || is_Sync(node) || is_Pin(node))
295
296
			return 0;
	}
297
	if(be_is_Keep(node) && get_irn_opcode(get_nodes_block(node)) == iro_Bad)
298
299
		return 0;

300
301
302
303
	switch(get_irn_opcode(node)) {
	case iro_End:
	case iro_NoMem:
	case iro_Bad:
304
	case iro_Unknown:
305
306
307
308
309
		return 0;
	default:
		break;
	}

310
	if (arch_irn_get_flags(node) & arch_irn_flags_ignore)
311
312
		return -1;

313
314
315
316
317
318
	return 1;
}

static void check_schedule(ir_node *node, void *data) {
	be_verify_schedule_env_t *env = data;
	int should_be;
319
	int scheduled;
320

321
	should_be = should_be_scheduled(node);
322
323
	if(should_be == -1)
		return;
324

325
326
327
	scheduled = bitset_is_set(env->scheduled, get_irn_idx(node)) ? 1 : 0;
	should_be = should_be ? 1 : 0;
	if(should_be != scheduled) {
328
		ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should%s be scheduled\n",
329
			node, get_nodes_block(node), get_irg_dump_name(env->irg), should_be ? "" : " not");
330
331
332
333
		env->problem_found = 1;
	}
}

Christian Würdig's avatar
Christian Würdig committed
334
335
336
/**
 * Start a walk over the irg and check schedule.
 */
337
int be_verify_schedule(const be_irg_t *birg)
338
339
340
341
{
	be_verify_schedule_env_t env;

	env.problem_found = 0;
342
343
	env.irg           = be_get_birg_irg(birg);
	env.scheduled     = bitset_alloca(get_irg_last_idx(env.irg));
344

345
	irg_block_walk_graph(env.irg, verify_schedule_walker, NULL, &env);
346
	/* check if all nodes are scheduled */
347
	irg_walk_graph(env.irg, check_schedule, NULL, &env);
348

Christian Würdig's avatar
Christian Würdig committed
349
	return ! env.problem_found;
350
}
351

352
353


354
/*--------------------------------------------------------------------------- */
355
356


357
358
359

typedef struct _spill_t {
	ir_node *spill;
360
	ir_entity *ent;
361
362
363
} spill_t;

typedef struct {
364
365
366
367
	ir_graph  *irg;
	set       *spills;
	ir_node  **reloads;
	int        problem_found;
368
369
370
371
372
} be_verify_spillslots_env_t;

static int cmp_spill(const void* d1, const void* d2, size_t size) {
	const spill_t* s1 = d1;
	const spill_t* s2 = d2;
373
374
	(void) size;

375
376
377
	return s1->spill != s2->spill;
}

378
379
380
381
382
383
384
static spill_t *find_spill(be_verify_spillslots_env_t *env, ir_node *node) {
	spill_t spill;

	spill.spill = node;
	return set_find(env->spills, &spill, sizeof(spill), HASH_PTR(node));
}

385
static spill_t *get_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_entity *ent) {
386
387
388
389
390
391
392
393
394
395
396
397
398
399
	spill_t spill, *res;
	int hash = HASH_PTR(node);

	spill.spill = node;
	res = set_find(env->spills, &spill, sizeof(spill), hash);

	if(res == NULL) {
		spill.ent = ent;
		res = set_insert(env->spills, &spill, sizeof(spill), hash);
	}

	return res;
}

400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
static ir_node *get_memory_edge(const ir_node *node) {
	int i, arity;
	ir_node *result = NULL;

	arity = get_irn_arity(node);
	for(i = arity - 1; i >= 0; --i) {
		ir_node *arg = get_irn_n(node, i);
		if(get_irn_mode(arg) == mode_M) {
			assert(result == NULL);
			result = arg;
		}
	}

	return result;
}

416
417
static
void collect(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent);
418

419
420
static
void be_check_entity(be_verify_spillslots_env_t *env, ir_node *node, ir_entity *ent) {
421
422
423
424
425
426
	if(ent == NULL) {
		ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should have an entity assigned\n",
		           node, get_nodes_block(node), get_irg_dump_name(env->irg));
	}
}

427
428
static
void collect_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent) {
429
	ir_entity *spillent = arch_get_frame_entity(node);
430
	be_check_entity(env, node, spillent);
431
432
433
434
435
436
437
438
439
	get_spill(env, node, ent);

	if(spillent != ent) {
		ir_fprintf(stderr, "Verify warning: Spill %+F has different entity than reload %+F in block %+F(%s)\n",
			node, reload, get_nodes_block(node), get_irg_dump_name(env->irg));
		env->problem_found = 1;
	}
}

440
static void collect_memperm(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent) {
441
442
443
444
445
	int i, arity;
	spill_t spill, *res;
	int hash = HASH_PTR(node);
	int out;
	ir_node* memperm;
446
	ir_entity *spillent;
447
448
449
450
451
452
453

	assert(is_Proj(node));

	memperm = get_Proj_pred(node);
	out = get_Proj_proj(node);

	spillent = be_get_MemPerm_out_entity(memperm, out);
454
	be_check_entity(env, memperm, spillent);
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
	if(spillent != ent) {
		ir_fprintf(stderr, "Verify warning: MemPerm %+F has different entity than reload %+F in block %+F(%s)\n",
			node, reload, get_nodes_block(node), get_irg_dump_name(env->irg));
		env->problem_found = 1;
	}

	spill.spill = node;
	res = set_find(env->spills, &spill, sizeof(spill), hash);
	if(res != NULL) {
		return;
	}

	spill.ent = spillent;
	res = set_insert(env->spills, &spill, sizeof(spill), hash);

470
471
	for(i = 0, arity = be_get_MemPerm_entity_arity(memperm); i < arity; ++i) {
		ir_node* arg = get_irn_n(memperm, i + 1);
472
		ir_entity* argent = be_get_MemPerm_in_entity(memperm, i);
473
474
475
476
477

		collect(env, arg, memperm, argent);
	}
}

478
static void collect_memphi(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity *ent) {
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
	int i, arity;
	spill_t spill, *res;
	int hash = HASH_PTR(node);

	assert(is_Phi(node));

	spill.spill = node;
	res = set_find(env->spills, &spill, sizeof(spill), hash);
	if(res != NULL) {
		return;
	}

	spill.ent = ent;
	res = set_insert(env->spills, &spill, sizeof(spill), hash);

494
	/* is 1 of the arguments a spill? */
495
496
497
498
499
500
	for(i = 0, arity = get_irn_arity(node); i < arity; ++i) {
		ir_node* arg = get_irn_n(node, i);
		collect(env, arg, reload, ent);
	}
}

501
static void collect(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent) {
502
503
504
505
506
507
508
	if(be_is_Spill(node)) {
		collect_spill(env, node, reload, ent);
	} else if(is_Proj(node)) {
		collect_memperm(env, node, reload, ent);
	} else if(is_Phi(node) && get_irn_mode(node) == mode_M) {
		collect_memphi(env, node, reload, ent);
	} else {
509
		/* Disabled for now, spills might get transformed by the backend */
510
#if 0
511
512
513
		ir_fprintf(stderr, "Verify warning: No spill, memperm or memphi attached to node %+F found from node %+F in block %+F(%s)\n",
			node, reload, get_nodes_block(node), get_irg_dump_name(env->irg));
		env->problem_found = 1;
514
#endif
515
516
517
518
519
520
521
522
523
524
	}
}

/**
 * This walker function searches for reloads and collects all the spills
 * and memphis attached to them.
 */
static void collect_spills_walker(ir_node *node, void *data) {
	be_verify_spillslots_env_t *env = data;

525
	/* @@@ ia32_classify returns classification of Proj_pred :-/ */
526
527
528
	if(is_Proj(node))
		return;

529
	if (arch_irn_class_is(node, reload)) {
530
		ir_node *spill = get_memory_edge(node);
531
		ir_entity *ent;
Matthias Braun's avatar
Matthias Braun committed
532

533
534
535
536
537
538
		if(spill == NULL) {
			ir_fprintf(stderr, "Verify warning: No spill attached to reload %+F in block %+F(%s)\n",
			           node, get_nodes_block(node), get_irg_dump_name(env->irg));
			env->problem_found = 1;
			return;
		}
539
		ent = arch_get_frame_entity(node);
540
		be_check_entity(env, node, ent);
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566

		collect(env, spill, node, ent);
		ARR_APP1(ir_node*, env->reloads, node);
	}
}

static void check_spillslot_interference(be_verify_spillslots_env_t *env) {
	int spillcount = set_count(env->spills);
	spill_t **spills = alloca(spillcount * sizeof(spills[0]));
	spill_t *spill;
	int i;

	for(spill = set_first(env->spills), i = 0; spill != NULL; spill = set_next(env->spills), ++i) {
		spills[i] = spill;
	}

	for(i = 0; i < spillcount; ++i) {
		spill_t *sp1 = spills[i];
		int i2;

		for(i2 = i+1; i2 < spillcount; ++i2) {
			spill_t *sp2 = spills[i2];

			if(sp1->ent != sp2->ent)
				continue;

567
			if(my_values_interfere(sp1->spill, sp2->spill)) {
568
569
570
571
				ir_fprintf(stderr, "Verify warning: Spillslots for %+F in block %+F(%s) and %+F in block %+F(%s) interfere\n",
					sp1->spill, get_nodes_block(sp1->spill), get_irg_dump_name(env->irg),
					sp2->spill, get_nodes_block(sp2->spill), get_irg_dump_name(env->irg));
				env->problem_found = 1;
572
				my_values_interfere(sp1->spill, sp2->spill);
573
574
575
576
577
			}
		}
	}
}

578
579
580
581
582
583
static void check_lonely_spills(ir_node *node, void *data) {
	be_verify_spillslots_env_t *env = data;

	if(be_is_Spill(node) || (is_Proj(node) && be_is_MemPerm(get_Proj_pred(node)))) {
		spill_t *spill = find_spill(env, node);
		if(be_is_Spill(node)) {
584
			ir_entity *ent = arch_get_frame_entity(node);
585
			be_check_entity(env, node, ent);
586
587
588
589
590
591
592
593
594
		}

		if(spill == NULL) {
			ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) not connected to a reaload\n",
			           node, get_nodes_block(node), get_irg_dump_name(env->irg));
		}
	}
}

595
int be_verify_spillslots(ir_graph *irg)
596
597
598
599
600
601
602
603
604
{
	be_verify_spillslots_env_t env;

	env.irg = irg;
	env.spills = new_set(cmp_spill, 10);
	env.reloads = NEW_ARR_F(ir_node*, 0);
	env.problem_found = 0;

	irg_walk_graph(irg, collect_spills_walker, NULL, &env);
605
	irg_walk_graph(irg, check_lonely_spills, NULL, &env);
606
607
608
609
610
611
612
613
614

	check_spillslot_interference(&env);

	DEL_ARR_F(env.reloads);
	del_set(env.spills);

	return ! env.problem_found;
}

615
616


617
/*--------------------------------------------------------------------------- */
618
619
620
621
622
623
624
625



/**
 * Check, if two values interfere.
 * @param a The first value.
 * @param b The second value.
 * @return 1, if a and b interfere, 0 if not.
626
 */
627
static int my_values_interfere(const ir_node *a, const ir_node *b) {
628
629
	const ir_edge_t *edge;
	ir_node *bb;
630
631
	int a2b = value_dominates(a, b);
	int b2a = value_dominates(b, a);
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664

	/* If there is no dominance relation, they do not interfere. */
	if(!a2b && !b2a)
		return 0;

	/*
	 * Adjust a and b so, that a dominates b if
	 * a dominates b or vice versa.
	 */
	if(b2a) {
		const ir_node *t = a;
		a = b;
		b = t;
	}

	bb = get_nodes_block(b);

	/*
	 * Look at all usages of a.
	 * If there's one usage of a in the block of b, then
	 * we check, if this use is dominated by b, if that's true
	 * a and b interfere. Note that b must strictly dominate the user,
	 * since if b is the last user of in the block, b and a do not
	 * interfere.
	 * Uses of a not in b's block can be disobeyed, because the
	 * check for a being live at the end of b's block is already
	 * performed.
	 */
	foreach_out_edge(a, edge) {
		const ir_node *user = get_edge_src_irn(edge);
		if(b == user)
			continue;

665
666
667
		if(get_irn_opcode(user) == iro_End)
			continue;

668
		/* in case of phi arguments we compare with the block the value comes from */
669
670
		if(is_Phi(user)) {
			ir_node *phiblock = get_nodes_block(user);
671
672
			if(phiblock == bb)
				continue;
673
674
675
			user = get_irn_n(phiblock, get_edge_src_pos(edge));
		}

676
		if(value_dominates(b, user))
677
678
679
680
681
			return 1;
	}

	return 0;
}
682
683
684



685
/*--------------------------------------------------------------------------- */
686

687
688
689
690
691
692
693
694
static const arch_env_t            *arch_env;
static ir_graph                    *irg;
static be_lv_t                     *lv;
static int                          problem_found;
static const arch_register_class_t *regclass;
static ir_node                    **registers;

static void check_register_constraints(ir_node *node)
695
{
696
	const arch_register_t *reg;
697
	int                   i, arity;
698

699
	/* verify output register */
700
	if (arch_get_irn_reg_class_out(node) != NULL) {
701
		reg = arch_get_irn_register(node);
702
		if (reg == NULL) {
703
			ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should have a register assigned\n",
704
705
					node, get_nodes_block(node), get_irg_dump_name(irg));
			problem_found = 1;
706
		} else if (!arch_register_type_is(reg, joker) && !arch_reg_is_allocatable(node, -1, reg)) {
707
			ir_fprintf(stderr, "Verify warning: Register %s assigned as output of %+F not allowed (register constraint) in block %+F(%s)\n",
708
709
					reg->name, node, get_nodes_block(node), get_irg_dump_name(irg));
			problem_found = 1;
710
711
712
		}
	}

713
	/* verify input register */
714
	arity = get_irn_arity(node);
715
	for (i = 0; i < arity; ++i) {
716
717
		ir_node *pred = get_irn_n(node, i);

718
719
720
		if (is_Unknown(pred))
			continue;

Christian Würdig's avatar
Christian Würdig committed
721
722
		if (is_Bad(pred)) {
			ir_fprintf(stderr, "Verify warning: %+F in block %+F(%s) has Bad as input %d\n",
723
724
				node, get_nodes_block(node), get_irg_dump_name(irg), i);
			problem_found = 1;
Christian Würdig's avatar
Christian Würdig committed
725
726
727
			continue;
		}

728
		if (arch_get_irn_reg_class(node, i) == NULL)
729
730
			continue;

731
		reg = arch_get_irn_register(pred);
732
		if (reg == NULL) {
733
			ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should have a register assigned (%+F input constraint)\n",
734
735
			           pred, get_nodes_block(pred), get_irg_dump_name(irg), node);
			problem_found = 1;
736
			continue;
737
		} else if (!arch_register_type_is(reg, joker) && ! arch_reg_is_allocatable(node, i, reg)) {
738
			ir_fprintf(stderr, "Verify warning: Register %s as input %d of %+F not allowed (register constraint) in block %+F(%s)\n",
739
740
			           reg->name, i, node, get_nodes_block(node), get_irg_dump_name(irg));
			problem_found = 1;
741
742
743
		}
	}

744
745
746
747
	/* phis should be NOPs at this point, which means all input regs
	 * must be the same as the output reg */
	if (is_Phi(node)) {
		int i, arity;
748

749
		reg = arch_get_irn_register(node);
750

751
752
753
		arity = get_irn_arity(node);
		for (i = 0; i < arity; ++i) {
			ir_node               *pred     = get_Phi_pred(node, i);
754
			const arch_register_t *pred_reg = arch_get_irn_register(pred);
755

756
			if (reg != pred_reg && !arch_register_type_is(pred_reg, joker)) {
757
758
				ir_fprintf(stderr, "Verify warning: Input %d of %+F in block %+F(%s) uses register %s instead of %s\n",
				           i, node, get_nodes_block(node), get_irg_dump_name(irg), pred_reg->name, reg->name);
759
760
				problem_found = 1;
			}
761
762
		}
	}
763
}
764

765
766
767
static void value_used(ir_node *node) {
	const arch_register_t *reg;
	ir_node               *reg_node;
768

769
	if (arch_get_irn_reg_class_out(node) != regclass)
770
771
		return;

772
	reg = arch_get_irn_register(node);
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
	if (reg->type & arch_register_type_virtual)
		return;

	reg_node = registers[reg->index];
	if (reg_node != NULL && reg_node != node) {
		ir_fprintf(stderr, "Verify warning: Register %s assigned more than once in block %+F(%s) (nodes %+F %+F)\n",
			       reg->name, get_nodes_block(node), get_irg_dump_name(irg),
			       node, reg_node);
		problem_found = 1;
	}

	registers[reg->index] = node;
}

static void value_def(ir_node *node)
{
	const arch_register_t *reg;
	ir_node               *reg_node;

792
	if (arch_get_irn_reg_class_out(node) != regclass)
793
794
		return;

795
	reg = arch_get_irn_register(node);
796
797
798
799
800
801
802
803
804
	if (reg->type & arch_register_type_virtual)
		return;

	reg_node = registers[reg->index];

	if (reg_node != node) {
		ir_fprintf(stderr, "Verify warning: Node %+F not registered as value for Register %s (but %+F) in block %+F(%s)\n",
			       node, reg->name, reg_node, get_nodes_block(node), get_irg_dump_name(irg));
		problem_found = 1;
805
	}
806
	registers[reg->index] = NULL;
807
808
809
810
}

static void verify_block_register_allocation(ir_node *block, void *data) {
	int i, nregclasses;
811
	(void) data;
812

813
	nregclasses = arch_env_get_n_reg_class(arch_env);
814
	for (i = 0; i < nregclasses; ++i) {
815
		ir_node               *node;
Michael Beck's avatar
Michael Beck committed
816
		int                   idx, i2, n_regs;
817
818

		regclass = arch_env_get_reg_class(arch_env, i);
819

820
821
		assert(lv->nodes && "live sets must be computed");

Michael Beck's avatar
Michael Beck committed
822
823
		n_regs    = arch_register_class_n_regs(regclass);
		registers = alloca(n_regs * sizeof(registers[0]));
824
825
		memset(registers, 0, n_regs * sizeof(registers[0]));

Michael Beck's avatar
Michael Beck committed
826
827
		be_lv_foreach(lv, block, be_lv_state_end, idx) {
			ir_node *node = be_lv_get_irn(lv, block, idx);
828
829
			value_used(node);
		}
830
831

		sched_foreach_reverse(block, node) {
832
833
834
835
836
837
838
839
840
841
842
843
844
			int arity;

			if (get_irn_mode(node) == mode_T) {
				const ir_edge_t *edge;
				foreach_out_edge(node, edge) {
					ir_node *def = get_edge_src_irn(edge);
					value_def(def);
				}
			} else {
				value_def(node);
			}

			check_register_constraints(node);
845
			if (is_Phi(node))
846
847
848
849
850
851
852
853
				continue;

			arity = get_irn_arity(node);
			for (i2 = 0; i2 < arity; ++i2) {
				ir_node *use = get_irn_n(node, i2);
				value_used(use);
			}
		}
854

Michael Beck's avatar
Michael Beck committed
855
856
		be_lv_foreach(lv, block, be_lv_state_in, idx) {
			ir_node *node = be_lv_get_irn(lv, block, idx);
857
			value_def(node);
858
859
		}

860
861
862
863
864
865
866
867
868
		/* set must be empty now */
		for (i2 = 0; i2 < n_regs; ++i2) {
			if (registers[i2] == NULL)
				continue;

			ir_fprintf(stderr, "Verify warning: Node %+F not live-in and no def found in block %+F(%s)\n",
					registers[i2], block, get_irg_dump_name(irg));
			problem_found = 1;
		}
869
870
871
	}
}

Sebastian Hack's avatar
Sebastian Hack committed
872
int be_verify_register_allocation(const be_irg_t *birg) {
873
874
875
876
	arch_env      = be_get_birg_arch_env(birg);
	irg           = be_get_birg_irg(birg);
	lv            = be_liveness(birg);
	problem_found = 0;
877

878
879
	be_liveness_assure_sets(lv);
	irg_block_walk_graph(irg, verify_block_register_allocation, NULL, NULL);
880

881
	be_liveness_free(lv);
882

883
	return !problem_found;
884
}
885
886
887



888
/*--------------------------------------------------------------------------- */
889
890
891
892
893
894
895
896
897
898



typedef struct _verify_out_dead_nodes_env {
	ir_graph *irg;
	bitset_t *reachable;
	int problem_found;
} verify_out_dead_nodes_env;

static void check_out_edges(ir_node *node, verify_out_dead_nodes_env *env) {
899
	ir_graph *irg = env->irg;
900
901
	const ir_edge_t* edge;

902
	if (irn_visited_else_mark(node))
903
904
		return;

905
906
907
908
	/* we find too many (uncritical) dead nodes in block out edges */
	if(is_Block(node))
		return;

909
910
911
	foreach_out_edge(node, edge) {
		ir_node* src = get_edge_src_irn(edge);

Matthias Braun's avatar
Matthias Braun committed
912
		if(!bitset_is_set(env->reachable, get_irn_idx(src)) && !is_Block(src)) {
Matthias Braun's avatar
Matthias Braun committed
913
914
915
			ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) only reachable through out edges from %+F\n",
			           src, get_nodes_block(src), get_irg_dump_name(irg), node);
			env->problem_found = 1;
916
			continue;
917
918
		}

Matthias Braun's avatar
Matthias Braun committed
919
		check_out_edges(src, env);
920
921
922
923
924
925
926
927
928
929
930
	}
}

static void set_reachable(ir_node *node, void* data)
{
	bitset_t* reachable = data;
	bitset_set(reachable, get_irn_idx(node));
}

int be_verify_out_edges(ir_graph *irg) {
	verify_out_dead_nodes_env env;
931
932
933
934

	env.irg           = irg;
	env.reachable     = bitset_alloca(get_irg_last_idx(irg));
	env.problem_found = edges_verify(irg);
935

936
	irg_walk_in_or_dep_graph(irg, set_reachable, NULL, env.reachable);
Matthias Braun's avatar
Matthias Braun committed
937
	irg_walk_anchors(irg, set_reachable, NULL, env.reachable);
938
	inc_irg_visited(irg);
939
940
	check_out_edges(get_irg_start(irg), &env);

941
	return ! env.problem_found;
942
}