ldstopt.c 34.1 KB
Newer Older
Christian Würdig's avatar
Christian Würdig committed
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
/*
 * Copyright (C) 1995-2007 University of Karlsruhe.  All right reserved.
 *
 * This file is part of libFirm.
 *
 * This file may be distributed and/or modified under the terms of the
 * GNU General Public License version 2 as published by the Free Software
 * Foundation and appearing in the file LICENSE.GPL included in the
 * packaging of this file.
 *
 * Licensees holding valid libFirm Professional Edition licenses may use
 * this file in accordance with the libFirm Commercial License.
 * Agreement provided with the Software.
 *
 * This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 * WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 * PURPOSE.
 */

Michael Beck's avatar
Michael Beck committed
20
21
22
23
24
/**
 * @file
 * @brief   Load/Store optimizations.
 * @author  Michael Beck
 * @version $Id$
Michael Beck's avatar
Michael Beck committed
25
 */
Michael Beck's avatar
Michael Beck committed
26
27
28
29
#ifdef HAVE_CONFIG_H
# include "config.h"
#endif

30
#include <string.h>
Michael Beck's avatar
Michael Beck committed
31

32
#include "iroptimize.h"
33
34
35
36
37
38
39
40
41
42
43
44
45
46
#include "irnode_t.h"
#include "irgraph_t.h"
#include "irmode_t.h"
#include "iropt_t.h"
#include "ircons_t.h"
#include "irgmod.h"
#include "irgwalk.h"
#include "irvrfy.h"
#include "tv_t.h"
#include "dbginfo_t.h"
#include "iropt_dbg.h"
#include "irflag_t.h"
#include "array.h"
#include "irhooks.h"
Michael Beck's avatar
BugFix:    
Michael Beck committed
47
#include "iredges.h"
48
49
#include "irtools.h"
#include "opt_polymorphy.h"
50
#include "irmemory.h"
51
#include "xmalloc.h"
52
53
54
55

#ifdef DO_CACHEOPT
#include "cacheopt/cachesim.h"
#endif
Michael Beck's avatar
Michael Beck committed
56
57
58
59
60
61

#undef IMAX
#define IMAX(a,b)	((a) > (b) ? (a) : (b))

#define MAX_PROJ	IMAX(pn_Load_max, pn_Store_max)

62
enum changes_t {
63
64
	DF_CHANGED = 1,       /**< data flow changed */
	CF_CHANGED = 2,       /**< control flow changed */
65
66
};

Michael Beck's avatar
Michael Beck committed
67
68
69
70
/**
 * walker environment
 */
typedef struct _walk_env_t {
71
72
	struct obstack obst;          /**< list of all stores */
	unsigned changes;             /**< a bitmask of graph changes */
Michael Beck's avatar
Michael Beck committed
73
74
} walk_env_t;

75
76
77
78
/**
 * flags for Load/Store
 */
enum ldst_flags_t {
79
	LDST_VISITED = 1              /**< if set, this Load/Store is already visited */
80
81
};

82
/** A Load/Store info. */
Michael Beck's avatar
Michael Beck committed
83
typedef struct _ldst_info_t {
84
85
86
87
88
	ir_node  *projs[MAX_PROJ];    /**< list of Proj's of this node */
	ir_node  *exc_block;          /**< the exception block if available */
	int      exc_idx;             /**< predecessor index in the exception block */
	unsigned flags;               /**< flags */
	unsigned visited;             /**< visited counter for breaking loops */
Michael Beck's avatar
Michael Beck committed
89
90
} ldst_info_t;

91
/**
92
 * flags for control flow.
93
94
 */
enum block_flags_t {
95
96
	BLOCK_HAS_COND = 1,      /**< Block has conditional control flow */
	BLOCK_HAS_EXC  = 2       /**< Block has exceptional control flow */
97
98
99
};

/**
100
 * a Block info.
101
102
 */
typedef struct _block_info_t {
103
	unsigned flags;               /**< flags for the block */
104
105
} block_info_t;

106
107
108
109
110
111
112
/** the master visited flag for loop detection. */
static unsigned master_visited = 0;

#define INC_MASTER()       ++master_visited
#define MARK_NODE(info)    (info)->visited = master_visited
#define NODE_VISITED(info) (info)->visited >= master_visited

Michael Beck's avatar
Michael Beck committed
113
114
115
/**
 * get the Load/Store info of a node
 */
116
static ldst_info_t *get_ldst_info(ir_node *node, walk_env_t *env) {
117
	ldst_info_t *info = get_irn_link(node);
Michael Beck's avatar
Michael Beck committed
118

119
120
121
122
123
124
125
	if (! info) {
		info = obstack_alloc(&env->obst, sizeof(*info));
		memset(info, 0, sizeof(*info));
		set_irn_link(node, info);
	}
	return info;
}  /* get_ldst_info */
Michael Beck's avatar
Michael Beck committed
126

127
128
129
/**
 * get the Block info of a node
 */
130
131
static block_info_t *get_block_info(ir_node *node, walk_env_t *env) {
	block_info_t *info = get_irn_link(node);
132

133
134
135
136
137
138
139
	if (! info) {
		info = obstack_alloc(&env->obst, sizeof(*info));
		memset(info, 0, sizeof(*info));
		set_irn_link(node, info);
	}
	return info;
}  /* get_block_info */
140

Michael Beck's avatar
Michael Beck committed
141
/**
Michael Beck's avatar
Michael Beck committed
142
 * update the projection info for a Load/Store
Michael Beck's avatar
Michael Beck committed
143
 */
144
static unsigned update_projs(ldst_info_t *info, ir_node *proj)
Michael Beck's avatar
Michael Beck committed
145
{
146
	long nr = get_Proj_proj(proj);
Michael Beck's avatar
Michael Beck committed
147

148
	assert(0 <= nr && nr <= MAX_PROJ && "Wrong proj from LoadStore");
Michael Beck's avatar
Michael Beck committed
149

150
151
152
153
154
155
156
157
158
159
	if (info->projs[nr]) {
		/* there is already one, do CSE */
		exchange(proj, info->projs[nr]);
		return DF_CHANGED;
	}
	else {
		info->projs[nr] = proj;
		return 0;
	}
}  /* update_projs */
Michael Beck's avatar
Michael Beck committed
160
161

/**
162
163
164
165
166
 * update the exception block info for a Load/Store node.
 *
 * @param info   the load/store info struct
 * @param block  the exception handler block for this load/store
 * @param pos    the control flow input of the block
Michael Beck's avatar
Michael Beck committed
167
 */
168
static unsigned update_exc(ldst_info_t *info, ir_node *block, int pos)
Michael Beck's avatar
Michael Beck committed
169
{
170
	assert(info->exc_block == NULL && "more than one exception block found");
Michael Beck's avatar
Michael Beck committed
171

172
173
174
175
	info->exc_block = block;
	info->exc_idx   = pos;
	return 0;
}  /* update_exc */
Michael Beck's avatar
Michael Beck committed
176

177
/** Return the number of uses of an address node */
Michael Beck's avatar
BugFix:    
Michael Beck committed
178
#define get_irn_n_uses(adr)     get_irn_n_edges(adr)
179

Michael Beck's avatar
Michael Beck committed
180
181
/**
 * walker, collects all Load/Store/Proj nodes
182
 *
183
 * walks from Start -> End
Michael Beck's avatar
Michael Beck committed
184
 */
Michael Beck's avatar
Michael Beck committed
185
static void collect_nodes(ir_node *node, void *env)
Michael Beck's avatar
Michael Beck committed
186
{
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
	ir_op       *op = get_irn_op(node);
	ir_node     *pred, *blk, *pred_blk;
	ldst_info_t *ldst_info;
	walk_env_t  *wenv = env;

	if (op == op_Proj) {
		ir_node *adr;
		ir_op *op;

		pred = get_Proj_pred(node);
		op   = get_irn_op(pred);

		if (op == op_Load) {
			ldst_info = get_ldst_info(pred, wenv);

			wenv->changes |= update_projs(ldst_info, node);

			if ((ldst_info->flags & LDST_VISITED) == 0) {
				adr = get_Load_ptr(pred);
				ldst_info->flags |= LDST_VISITED;
			}

			/*
210
211
212
213
214
			 * Place the Proj's to the same block as the
			 * predecessor Load. This is always ok and prevents
			 * "non-SSA" form after optimizations if the Proj
			 * is in a wrong block.
			 */
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
			blk      = get_nodes_block(node);
			pred_blk = get_nodes_block(pred);
			if (blk != pred_blk) {
				wenv->changes |= DF_CHANGED;
				set_nodes_block(node, pred_blk);
			}
		} else if (op == op_Store) {
			ldst_info = get_ldst_info(pred, wenv);

			wenv->changes |= update_projs(ldst_info, node);

			if ((ldst_info->flags & LDST_VISITED) == 0) {
				adr = get_Store_ptr(pred);
				ldst_info->flags |= LDST_VISITED;
			}

			/*
			* Place the Proj's to the same block as the
			* predecessor Store. This is always ok and prevents
			* "non-SSA" form after optimizations if the Proj
			* is in a wrong block.
			*/
			blk      = get_nodes_block(node);
			pred_blk = get_nodes_block(pred);
			if (blk != pred_blk) {
				wenv->changes |= DF_CHANGED;
				set_nodes_block(node, pred_blk);
			}
		}
	} else if (op == op_Block) {
		int i;

		for (i = get_Block_n_cfgpreds(node) - 1; i >= 0; --i) {
248
			ir_node      *pred_block, *proj;
249
			block_info_t *bl_info;
250
251
252
			int          is_exc = 0;

			pred = proj = get_Block_cfgpred(node, i);
253

254
255
256
257
			if (is_Proj(proj)) {
				pred   = get_Proj_pred(proj);
				is_exc = get_Proj_proj(proj) == pn_Generic_X_except;
			}
258
259
260
261
262
263
264
265

			/* ignore Bad predecessors, they will be removed later */
			if (is_Bad(pred))
				continue;

			pred_block = get_nodes_block(pred);
			bl_info    = get_block_info(pred_block, wenv);

266
			if (is_fragile_op(pred) && is_exc)
267
268
269
270
				bl_info->flags |= BLOCK_HAS_EXC;
			else if (is_irn_forking(pred))
				bl_info->flags |= BLOCK_HAS_COND;

271
			if (is_exc && (get_irn_op(pred) == op_Load || get_irn_op(pred) == op_Store)) {
272
273
274
275
276
277
278
				ldst_info = get_ldst_info(pred, wenv);

				wenv->changes |= update_exc(ldst_info, node, i);
			}
		}
	}
}  /* collect_nodes */
Michael Beck's avatar
Michael Beck committed
279

Michael Beck's avatar
Michael Beck committed
280
/**
281
 * Returns an entity if the address ptr points to a constant one.
282
283
284
285
 *
 * @param ptr  the address
 *
 * @return an entity or NULL
Michael Beck's avatar
Michael Beck committed
286
 */
287
static ir_entity *find_constant_entity(ir_node *ptr)
Michael Beck's avatar
Michael Beck committed
288
{
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
	for (;;) {
		ir_op *op = get_irn_op(ptr);

		if (op == op_SymConst && (get_SymConst_kind(ptr) == symconst_addr_ent)) {
			ir_entity *ent = get_SymConst_entity(ptr);
			if (variability_constant == get_entity_variability(ent))
				return ent;
			return NULL;
		} else if (op == op_Sel) {
			ir_entity *ent = get_Sel_entity(ptr);
			ir_type   *tp  = get_entity_owner(ent);

			/* Do not fiddle with polymorphism. */
			if (is_Class_type(get_entity_owner(ent)) &&
				((get_entity_n_overwrites(ent)    != 0) ||
				(get_entity_n_overwrittenby(ent) != 0)   ) )
				return NULL;

			if (is_Array_type(tp)) {
				/* check bounds */
				int i, n;

				for (i = 0, n = get_Sel_n_indexs(ptr); i < n; ++i) {
					ir_node *bound;
					tarval *tlower, *tupper;
					ir_node *index = get_Sel_index(ptr, i);
					tarval *tv     = computed_value(index);

					/* check if the index is constant */
					if (tv == tarval_bad)
						return NULL;

					bound  = get_array_lower_bound(tp, i);
					tlower = computed_value(bound);
					bound  = get_array_upper_bound(tp, i);
					tupper = computed_value(bound);

					if (tlower == tarval_bad || tupper == tarval_bad)
						return NULL;

					if (tarval_cmp(tv, tlower) & pn_Cmp_Lt)
						return NULL;
					if (tarval_cmp(tupper, tv) & pn_Cmp_Lt)
						return NULL;

					/* ok, bounds check finished */
				}
			}

			if (variability_constant == get_entity_variability(ent))
				return ent;

			/* try next */
			ptr = get_Sel_ptr(ptr);
		} else
			return NULL;
	}
}  /* find_constant_entity */
Michael Beck's avatar
Michael Beck committed
347

Michael Beck's avatar
Michael Beck committed
348
349
350
/**
 * Return the Selection index of a Sel node from dimension n
 */
351
static long get_Sel_array_index_long(ir_node *n, int dim) {
352
353
354
355
	ir_node *index = get_Sel_index(n, dim);
	assert(get_irn_op(index) == op_Const);
	return get_tarval_long(get_Const_tarval(index));
}  /* get_Sel_array_index_long */
356

Michael Beck's avatar
Michael Beck committed
357
358
359
360
361
362
363
364
/**
 * Returns the accessed component graph path for an
 * node computing an address.
 *
 * @param ptr    the node computing the address
 * @param depth  current depth in steps upward from the root
 *               of the address
 */
Götz Lindenmaier's avatar
bugfix    
Götz Lindenmaier committed
365
static compound_graph_path *rec_get_accessed_path(ir_node *ptr, int depth) {
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
	compound_graph_path *res = NULL;
	ir_entity           *root, *field;
	int                 path_len, pos;

	if (get_irn_op(ptr) == op_SymConst) {
		/* a SymConst. If the depth is 0, this is an access to a global
		 * entity and we don't need a component path, else we know
		 * at least it's length.
		 */
		assert(get_SymConst_kind(ptr) == symconst_addr_ent);
		root = get_SymConst_entity(ptr);
		res = (depth == 0) ? NULL : new_compound_graph_path(get_entity_type(root), depth);
	} else {
		assert(get_irn_op(ptr) == op_Sel);
		/* it's a Sel, go up until we find the root */
		res = rec_get_accessed_path(get_Sel_ptr(ptr), depth+1);

		/* fill up the step in the path at the current position */
		field    = get_Sel_entity(ptr);
		path_len = get_compound_graph_path_length(res);
		pos      = path_len - depth - 1;
		set_compound_graph_path_node(res, pos, field);

		if (is_Array_type(get_entity_owner(field))) {
			assert(get_Sel_n_indexs(ptr) == 1 && "multi dim arrays not implemented");
			set_compound_graph_path_array_index(res, pos, get_Sel_array_index_long(ptr, 0));
		}
	}
	return res;
}  /* rec_get_accessed_path */
396

Götz Lindenmaier's avatar
bugfix    
Götz Lindenmaier committed
397
/** Returns an access path or NULL.  The access path is only
Michael Beck's avatar
Michael Beck committed
398
399
 *  valid, if the graph is in phase_high and _no_ address computation is used.
 */
Götz Lindenmaier's avatar
bugfix    
Götz Lindenmaier committed
400
static compound_graph_path *get_accessed_path(ir_node *ptr) {
401
402
	return rec_get_accessed_path(ptr, 0);
}  /* get_accessed_path */
403

404
405
406
407
408
409
410
/* forward */
static void reduce_adr_usage(ir_node *ptr);

/**
 * Update a Load that may lost it's usage.
 */
static void handle_load_update(ir_node *load) {
411
	ldst_info_t *info = get_irn_link(load);
412

413
414
415
	/* do NOT touch volatile loads for now */
	if (get_Load_volatility(load) == volatility_is_volatile)
		return;
416

417
418
419
	if (! info->projs[pn_Load_res] && ! info->projs[pn_Load_X_except]) {
		ir_node *ptr = get_Load_ptr(load);
		ir_node *mem = get_Load_mem(load);
420

421
422
423
424
425
426
		/* a Load which value is neither used nor exception checked, remove it */
		exchange(info->projs[pn_Load_M], mem);
		exchange(load, new_Bad());
		reduce_adr_usage(ptr);
	}
}  /* handle_load_update */
427
428
429
430
431
432

/**
 * A Use of an address node is vanished. Check if this was a Proj
 * node and update the counters.
 */
static void reduce_adr_usage(ir_node *ptr) {
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
	if (is_Proj(ptr)) {
		if (get_irn_n_edges(ptr) <= 0) {
			/* this Proj is dead now */
			ir_node *pred = get_Proj_pred(ptr);

			if (is_Load(pred)) {
				ldst_info_t *info = get_irn_link(pred);
				info->projs[get_Proj_proj(ptr)] = NULL;

				/* this node lost it's result proj, handle that */
				handle_load_update(pred);
			}
		}
	}
}  /* reduce_adr_usage */
448

449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
/**
 * Check, if an already existing value of mode old_mode can be converted
 * into the needed one new_mode without loss.
 */
static int can_use_stored_value(ir_mode *old_mode, ir_mode *new_mode) {
	if (old_mode == new_mode)
		return 1;

	/* if both modes are two-complement ones, we can always convert the
	   Stored value into the needed one. */
	if (get_mode_size_bits(old_mode) >= get_mode_size_bits(new_mode) &&
		  get_mode_arithmetic(old_mode) == irma_twos_complement &&
		  get_mode_arithmetic(new_mode) == irma_twos_complement)
		return 1;
	return 0;
}  /* can_use_stored_value */

Michael Beck's avatar
Michael Beck committed
466
467
/**
 * Follow the memory chain as long as there are only Loads
468
469
 * and alias free Stores and try to replace current Load or Store
 * by a previous ones.
Michael Beck's avatar
Michael Beck committed
470
471
472
473
474
475
 * Note that in unreachable loops it might happen that we reach
 * load again, as well as we can fall into a cycle.
 * We break such cycles using a special visited flag.
 *
 * INC_MASTER() must be called before dive into
 */
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
static unsigned follow_Mem_chain(ir_node *load, ir_node *curr) {
	unsigned res = 0;
	ldst_info_t *info = get_irn_link(load);
	ir_node *pred;
	ir_node *ptr       = get_Load_ptr(load);
	ir_node *mem       = get_Load_mem(load);
	ir_mode *load_mode = get_Load_mode(load);

	for (pred = curr; load != pred; ) {
		ldst_info_t *pred_info = get_irn_link(pred);

		/*
		 * BEWARE: one might think that checking the modes is useless, because
		 * if the pointers are identical, they refer to the same object.
		 * This is only true in strong typed languages, not in C were the following
		 * is possible a = *(ir_type1 *)p; b = *(ir_type2 *)p ...
		 */
		if (get_irn_op(pred) == op_Store && get_Store_ptr(pred) == ptr &&
494
		    can_use_stored_value(get_irn_mode(get_Store_value(pred)), load_mode)) {
495
496
497
498
499
500
501
502
503
504
505
506
			/*
			 * a Load immediately after a Store -- a read after write.
			 * We may remove the Load, if both Load & Store does not have an exception handler
			 * OR they are in the same block. In the latter case the Load cannot
			 * throw an exception when the previous Store was quiet.
			 *
			 * Why we need to check for Store Exception? If the Store cannot
			 * be executed (ROM) the exception handler might simply jump into
			 * the load block :-(
			 * We could make it a little bit better if we would know that the exception
			 * handler of the Store jumps directly to the end...
			 */
507
			if ((pred_info->projs[pn_Store_X_except] == NULL && info->projs[pn_Load_X_except] == NULL) ||
508
509
510
511
			    get_nodes_block(load) == get_nodes_block(pred)) {
				ir_node *value = get_Store_value(pred);

				DBG_OPT_RAW(load, value);
512
513
514
515
516
517

				/* add an convert if needed */
				if (get_irn_mode(get_Store_value(pred)) != load_mode) {
					value = new_r_Conv(current_ir_graph, get_nodes_block(load), value, load_mode);
				}

518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
				if (info->projs[pn_Load_M])
					exchange(info->projs[pn_Load_M], mem);

				/* no exception */
				if (info->projs[pn_Load_X_except]) {
					exchange( info->projs[pn_Load_X_except], new_Bad());
					res |= CF_CHANGED;
				}

				if (info->projs[pn_Load_res])
					exchange(info->projs[pn_Load_res], value);

				exchange(load, new_Bad());
				reduce_adr_usage(ptr);
				return res | DF_CHANGED;
			}
		} else if (get_irn_op(pred) == op_Load && get_Load_ptr(pred) == ptr &&
535
		           can_use_stored_value(get_Load_mode(pred), load_mode)) {
536
537
538
539
540
541
542
543
544
			/*
			 * a Load after a Load -- a read after read.
			 * We may remove the second Load, if it does not have an exception handler
			 * OR they are in the same block. In the later case the Load cannot
			 * throw an exception when the previous Load was quiet.
			 *
			 * Here, there is no need to check if the previous Load has an exception
			 * hander because they would have exact the same exception...
			 */
545
546
547
			if (info->projs[pn_Load_X_except] == NULL || get_nodes_block(load) == get_nodes_block(pred)) {
				ir_node *value;

548
549
				DBG_OPT_RAR(load, pred);

550
551
552
553
554
555
556
				/* the result is used */
				if (info->projs[pn_Load_res]) {
					if (pred_info->projs[pn_Load_res] == NULL) {
						/* create a new Proj again */
						pred_info->projs[pn_Load_res] = new_r_Proj(current_ir_graph, get_nodes_block(pred), pred, get_Load_mode(pred), pn_Load_res);
					}
					value = pred_info->projs[pn_Load_res];
557
558
559
560
561
562

					/* add an convert if needed */
					if (get_Load_mode(pred) != load_mode) {
						value = new_r_Conv(current_ir_graph, get_nodes_block(load), value, load_mode);
					}

563
					exchange(info->projs[pn_Load_res], value);
564
565
				}

566
567
568
				if (info->projs[pn_Load_M])
					exchange(info->projs[pn_Load_M], mem);

569
570
571
572
573
574
575
576
577
578
579
580
581
				/* no exception */
				if (info->projs[pn_Load_X_except]) {
					exchange(info->projs[pn_Load_X_except], new_Bad());
					res |= CF_CHANGED;
				}

				exchange(load, new_Bad());
				reduce_adr_usage(ptr);
				return res |= DF_CHANGED;
			}
		}

		if (get_irn_op(pred) == op_Store) {
582
			/* check if we can pass through this store */
583
584
585
586
			ir_alias_relation rel = get_alias_relation(
				current_ir_graph,
				get_Store_ptr(pred),
				get_irn_mode(get_Store_value(pred)),
587
				ptr, load_mode);
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
			/* if the might be an alias, we cannot pass this Store */
			if (rel != no_alias)
				break;
			pred = skip_Proj(get_Store_mem(pred));
		} else if (get_irn_op(pred) == op_Load) {
			pred = skip_Proj(get_Load_mem(pred));
		} else {
			/* follow only Load chains */
			break;
		}

		/* check for cycles */
		if (NODE_VISITED(pred_info))
			break;
		MARK_NODE(pred_info);
	}

	if (get_irn_op(pred) == op_Sync) {
		int i;

		/* handle all Sync predecessors */
		for (i = get_Sync_n_preds(pred) - 1; i >= 0; --i) {
			res |= follow_Mem_chain(load, skip_Proj(get_Sync_pred(pred, i)));
			if (res)
				break;
		}
	}

	return res;
}  /* follow_Mem_chain */
Michael Beck's avatar
Michael Beck committed
618

Michael Beck's avatar
Michael Beck committed
619
620
/**
 * optimize a Load
621
622
 *
 * @param load  the Load node
Michael Beck's avatar
Michael Beck committed
623
 */
624
static unsigned optimize_load(ir_node *load)
Michael Beck's avatar
Michael Beck committed
625
{
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
	ldst_info_t *info = get_irn_link(load);
	ir_node *mem, *ptr, *new_node;
	ir_entity *ent;
	unsigned res = 0;

	/* do NOT touch volatile loads for now */
	if (get_Load_volatility(load) == volatility_is_volatile)
		return 0;

	/* the address of the load to be optimized */
	ptr = get_Load_ptr(load);

	/*
	 * Check if we can remove the exception from a Load:
	 * This can be done, if the address is from an Sel(Alloc) and
	 * the Sel type is a subtype of the allocated type.
	 *
	 * This optimizes some often used OO constructs,
	 * like x = new O; x->t;
	 */
	if (info->projs[pn_Load_X_except]) {
		if (is_Sel(ptr)) {
			ir_node *mem = get_Sel_mem(ptr);

			/* FIXME: works with the current FE, but better use the base */
			if (get_irn_op(skip_Proj(mem)) == op_Alloc) {
				/* ok, check the types */
				ir_entity *ent    = get_Sel_entity(ptr);
				ir_type   *s_type = get_entity_type(ent);
				ir_type   *a_type = get_Alloc_type(mem);

				if (is_SubClass_of(s_type, a_type)) {
					/* ok, condition met: there can't be an exception because
					* Alloc guarantees that enough memory was allocated */

					exchange(info->projs[pn_Load_X_except], new_Bad());
					info->projs[pn_Load_X_except] = NULL;
					res |= CF_CHANGED;
				}
			}
		} else if ((get_irn_op(skip_Proj(ptr)) == op_Alloc) ||
			((get_irn_op(ptr) == op_Cast) && (get_irn_op(skip_Proj(get_Cast_op(ptr))) == op_Alloc))) {
				/* simple case: a direct load after an Alloc. Firm Alloc throw
				 * an exception in case of out-of-memory. So, there is no way for an
				 * exception in this load.
				 * This code is constructed by the "exception lowering" in the Jack compiler.
				 */
				exchange(info->projs[pn_Load_X_except], new_Bad());
				info->projs[pn_Load_X_except] = NULL;
				res |= CF_CHANGED;
		}
	}

	/* The mem of the Load. Must still be returned after optimization. */
	mem  = get_Load_mem(load);

	if (! info->projs[pn_Load_res] && ! info->projs[pn_Load_X_except]) {
		/* a Load which value is neither used nor exception checked, remove it */
		exchange(info->projs[pn_Load_M], mem);

		exchange(load, new_Bad());
		reduce_adr_usage(ptr);
		return res | DF_CHANGED;
	}

	/* Load from a constant polymorphic field, where we can resolve
	   polymorphism. */
	new_node = transform_node_Load(load);
	if (new_node != load) {
		if (info->projs[pn_Load_M]) {
			exchange(info->projs[pn_Load_M], mem);
			info->projs[pn_Load_M] = NULL;
		}
		if (info->projs[pn_Load_X_except]) {
			exchange(info->projs[pn_Load_X_except], new_Bad());
			info->projs[pn_Load_X_except] = NULL;
		}
		if (info->projs[pn_Load_res])
			exchange(info->projs[pn_Load_res], new_node);

		exchange(load, new_Bad());
		reduce_adr_usage(ptr);
		return res | DF_CHANGED;
	}

	/* check if we can determine the entity that will be loaded */
	ent = find_constant_entity(ptr);
	if (ent) {
		if ((allocation_static == get_entity_allocation(ent)) &&
			(visibility_external_allocated != get_entity_visibility(ent))) {
			/* a static allocation that is not external: there should be NO exception
			 * when loading. */

			/* no exception, clear the info field as it might be checked later again */
			if (info->projs[pn_Load_X_except]) {
				exchange(info->projs[pn_Load_X_except], new_Bad());
				info->projs[pn_Load_X_except] = NULL;
				res |= CF_CHANGED;
			}

			if (variability_constant == get_entity_variability(ent)
				&& is_atomic_entity(ent)) {
				/* Might not be atomic after
				   lowering of Sels.  In this
				   case we could also load, but
				   it's more complicated. */
				/* more simpler case: we load the content of a constant value:
				 * replace it by the constant itself
				 */

				/* no memory */
				if (info->projs[pn_Load_M]) {
					exchange(info->projs[pn_Load_M], mem);
					res |= DF_CHANGED;
				}
				/* no result :-) */
				if (info->projs[pn_Load_res]) {
					if (is_atomic_entity(ent)) {
						ir_node *c = copy_const_value(get_irn_dbg_info(load), get_atomic_ent_value(ent));

						DBG_OPT_RC(load, c);
						exchange(info->projs[pn_Load_res], c);
						res |= DF_CHANGED;
					}
				}
				exchange(load, new_Bad());
				reduce_adr_usage(ptr);
				return res;
			} else if (variability_constant == get_entity_variability(ent)) {
				compound_graph_path *path = get_accessed_path(ptr);

				if (path) {
					ir_node *c;

					assert(is_proper_compound_graph_path(path, get_compound_graph_path_length(path)-1));
					/*
					{
						int j;
						for (j = 0; j < get_compound_graph_path_length(path); ++j) {
							ir_entity *node = get_compound_graph_path_node(path, j);
							fprintf(stdout, ".%s", get_entity_name(node));
							if (is_Array_type(get_entity_owner(node)))
								fprintf(stdout, "[%d]", get_compound_graph_path_array_index(path, j));
						}
						printf("\n");
					}
					*/

					c = get_compound_ent_value_by_path(ent, path);
					free_compound_graph_path(path);

					/* printf("  cons: "); DDMN(c); */

					if (info->projs[pn_Load_M]) {
						exchange(info->projs[pn_Load_M], mem);
						res |= DF_CHANGED;
					}
					if (info->projs[pn_Load_res]) {
						exchange(info->projs[pn_Load_res], copy_const_value(get_irn_dbg_info(load), c));
						res |= DF_CHANGED;
					}
					exchange(load, new_Bad());
					reduce_adr_usage(ptr);
					return res;
				} else {
					/*  We can not determine a correct access path.  E.g., in jack, we load
					a byte from an object to generate an exception.   Happens in test program
					Reflectiontest.
					printf(">>>>>>>>>>>>> Found access to constant entity %s in function %s\n", get_entity_name(ent),
					get_entity_name(get_irg_entity(current_ir_graph)));
					printf("  load: "); DDMN(load);
					printf("  ptr:  "); DDMN(ptr);
					*/
				}
			}
		}
	}

	/* Check, if the address of this load is used more than once.
	 * If not, this load cannot be removed in any case. */
	if (get_irn_n_uses(ptr) <= 1)
		return res;

	/*
	 * follow the memory chain as long as there are only Loads
	 * and try to replace current Load or Store by a previous one.
	 * Note that in unreachable loops it might happen that we reach
	 * load again, as well as we can fall into a cycle.
	 * We break such cycles using a special visited flag.
	 */
	INC_MASTER();
	res = follow_Mem_chain(load, skip_Proj(mem));
	return res;
}  /* optimize_load */
Michael Beck's avatar
Michael Beck committed
820

821
822
823
824
825
826
827
828
829
/**
 * Check whether a value of mode new_mode would completely overwrite a value
 * of mode old_mode in memory.
 */
static int is_completely_overwritten(ir_mode *old_mode, ir_mode *new_mode)
{
	return get_mode_size_bits(new_mode) >= get_mode_size_bits(old_mode);
}  /* is_completely_overwritten */

Michael Beck's avatar
Michael Beck committed
830
/**
831
 * follow the memory chain as long as there are only Loads and alias free Stores.
Michael Beck's avatar
Michael Beck committed
832
833
834
 *
 * INC_MASTER() must be called before dive into
 */
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
static unsigned follow_Mem_chain_for_Store(ir_node *store, ir_node *curr) {
	unsigned res = 0;
	ldst_info_t *info = get_irn_link(store);
	ir_node *pred;
	ir_node *ptr = get_Store_ptr(store);
	ir_node *mem = get_Store_mem(store);
	ir_node *value = get_Store_value(store);
	ir_mode *mode  = get_irn_mode(value);
	ir_node *block = get_nodes_block(store);

	for (pred = curr; pred != store;) {
		ldst_info_t *pred_info = get_irn_link(pred);

		/*
		 * BEWARE: one might think that checking the modes is useless, because
		 * if the pointers are identical, they refer to the same object.
		 * This is only true in strong typed languages, not is C were the following
		 * is possible *(ir_type1 *)p = a; *(ir_type2 *)p = b ...
853
854
		 * However, if the mode that is written have a bigger  or equal size the the old
		 * one, the old value is completely overwritten and can be killed ...
855
856
		 */
		if (get_irn_op(pred) == op_Store && get_Store_ptr(pred) == ptr &&
857
858
		    get_nodes_block(pred) == block &&
		    is_completely_overwritten(get_irn_mode(get_Store_value(pred)), mode)) {
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
			/*
			 * a Store after a Store in the same block -- a write after write.
			 * We may remove the first Store, if it does not have an exception handler.
			 *
			 * TODO: What, if both have the same exception handler ???
			 */
			if (get_Store_volatility(pred) != volatility_is_volatile && !pred_info->projs[pn_Store_X_except]) {
				DBG_OPT_WAW(pred, store);
				exchange( pred_info->projs[pn_Store_M], get_Store_mem(pred) );
				exchange(pred, new_Bad());
				reduce_adr_usage(ptr);
				return DF_CHANGED;
			}
		} else if (get_irn_op(pred) == op_Load && get_Load_ptr(pred) == ptr &&
		           value == pred_info->projs[pn_Load_res]) {
			/*
			 * a Store of a value after a Load -- a write after read.
			 * We may remove the second Store, if it does not have an exception handler.
			 */
			if (! info->projs[pn_Store_X_except]) {
				DBG_OPT_WAR(store, pred);
				exchange( info->projs[pn_Store_M], mem );
				exchange(store, new_Bad());
				reduce_adr_usage(ptr);
				return DF_CHANGED;
			}
		}

		if (get_irn_op(pred) == op_Store) {
			/* check if we can pass thru this store */
			ir_alias_relation rel = get_alias_relation(
				current_ir_graph,
				get_Store_ptr(pred),
				get_irn_mode(get_Store_value(pred)),
893
				ptr, mode);
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
			/* if the might be an alias, we cannot pass this Store */
			if (rel != no_alias)
				break;
			pred = skip_Proj(get_Store_mem(pred));
		} else if (get_irn_op(pred) == op_Load) {
			pred = skip_Proj(get_Load_mem(pred));
		} else {
			/* follow only Load chains */
			break;
		}

		/* check for cycles */
		if (NODE_VISITED(pred_info))
			break;
		MARK_NODE(pred_info);
	}

	if (get_irn_op(pred) == op_Sync) {
		int i;

		/* handle all Sync predecessors */
		for (i = get_Sync_n_preds(pred) - 1; i >= 0; --i) {
			res |= follow_Mem_chain_for_Store(store, skip_Proj(get_Sync_pred(pred, i)));
			if (res)
				break;
		}
	}
	return res;
}  /* follow_Mem_chain_for_Store */
Michael Beck's avatar
Michael Beck committed
923
924
925

/**
 * optimize a Store
926
927
 *
 * @param store  the Store node
Michael Beck's avatar
Michael Beck committed
928
 */
929
930
static unsigned optimize_store(ir_node *store) {
	ir_node *ptr, *mem;
Michael Beck's avatar
Michael Beck committed
931

932
933
	if (get_Store_volatility(store) == volatility_is_volatile)
		return 0;
Michael Beck's avatar
Michael Beck committed
934

935
	ptr = get_Store_ptr(store);
936

937
938
939
940
	/* Check, if the address of this Store is used more than once.
	 * If not, this Store cannot be removed in any case. */
	if (get_irn_n_uses(ptr) <= 1)
		return 0;
941

942
	mem = get_Store_mem(store);
Michael Beck's avatar
Michael Beck committed
943

944
945
946
947
	/* follow the memory chain as long as there are only Loads */
	INC_MASTER();
	return follow_Mem_chain_for_Store(store, skip_Proj(mem));
}  /* optimize_store */
Michael Beck's avatar
Michael Beck committed
948

Michael Beck's avatar
Michael Beck committed
949
/**
950
 * walker, optimizes Phi after Stores to identical places:
Michael Beck's avatar
Michael Beck committed
951
 * Does the following optimization:
952
 * @verbatim
Michael Beck's avatar
Michael Beck committed
953
954
955
 *
 *   val1   val2   val3          val1  val2  val3
 *    |      |      |               \    |    /
956
 *  Store  Store  Store              \   |   /
957
 *      \    |    /                   PhiData
Michael Beck's avatar
Michael Beck committed
958
 *       \   |   /                       |
959
 *        \  |  /                      Store
960
 *          PhiM
Michael Beck's avatar
Michael Beck committed
961
 *
962
 * @endverbatim
963
964
 * This reduces the number of stores and allows for predicated execution.
 * Moves Stores back to the end of a function which may be bad.
Michael Beck's avatar
Michael Beck committed
965
 *
966
 * This is only possible if the predecessor blocks have only one successor.
Michael Beck's avatar
Michael Beck committed
967
 */
968
static unsigned optimize_phi(ir_node *phi, walk_env_t *wenv)
Michael Beck's avatar
Michael Beck committed
969
{
970
971
972
	int i, n;
	ir_node *store, *old_store, *ptr, *block, *phi_block, *phiM, *phiD, *exc, *projM;
	ir_mode *mode;
973
	ir_node **inM, **inD, **projMs;
974
975
976
977
978
979
980
981
982
983
984
985
986
987
	int *idx;
	dbg_info *db = NULL;
	ldst_info_t *info;
	block_info_t *bl_info;
	unsigned res = 0;

	/* Must be a memory Phi */
	if (get_irn_mode(phi) != mode_M)
		return 0;

	n = get_Phi_n_preds(phi);
	if (n <= 0)
		return 0;

Matthias Braun's avatar
Matthias Braun committed
988
989
990
991
992
993
	/* must be only one user */
	projM = get_Phi_pred(phi, 0);
	if (get_irn_n_edges(projM) != 1)
		return 0;

	store = skip_Proj(projM);
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
	old_store = store;
	if (get_irn_op(store) != op_Store)
		return 0;

	block = get_nodes_block(store);

	/* abort on dead blocks */
	if (is_Block_dead(block))
		return 0;

	/* check if the block is post dominated by Phi-block
	   and has no exception exit */
	bl_info = get_irn_link(block);
	if (bl_info->flags & BLOCK_HAS_EXC)
		return 0;

	phi_block = get_nodes_block(phi);
1011
	if (! block_strictly_postdominates(phi_block, block))
1012
1013
1014
1015
1016
1017
1018
1019
1020
		return 0;

	/* this is the address of the store */
	ptr  = get_Store_ptr(store);
	mode = get_irn_mode(get_Store_value(store));
	info = get_irn_link(store);
	exc  = info->exc_block;

	for (i = 1; i < n; ++i) {
Matthias Braun's avatar
Matthias Braun committed
1021
1022
1023
1024
		ir_node *pred = get_Phi_pred(phi, i);

		if (get_irn_n_edges(pred) != 1)
			return 0;
1025

Matthias Braun's avatar
Matthias Braun committed
1026
		pred = skip_Proj(pred);
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
		if (get_irn_op(pred) != op_Store)
			return 0;

		if (ptr != get_Store_ptr(pred) || mode != get_irn_mode(get_Store_value(pred)))
			return 0;

		info = get_irn_link(pred);

		/* check, if all stores have the same exception flow */
		if (exc != info->exc_block)
			return 0;

		/* abort on dead blocks */
		block = get_nodes_block(pred);
		if (is_Block_dead(block))
			return 0;

		/* check if the block is post dominated by Phi-block
		   and has no exception exit. Note that block must be different from
		   Phi-block, else we would move a Store from end End of a block to its
		   Start... */
		bl_info = get_irn_link(block);
		if (bl_info->flags & BLOCK_HAS_EXC)
			return 0;
		if (block == phi_block || ! block_postdominates(phi_block, block))
			return 0;
	}

	/*
	 * ok, when we are here, we found all predecessors of a Phi that
	 * are Stores to the same address and size. That means whatever
	 * we do before we enter the block of the Phi, we do a Store.
	 * So, we can move the Store to the current block:
	 *
	 *   val1    val2    val3          val1  val2  val3
	 *    |       |       |               \    |    /
	 * | Str | | Str | | Str |             \   |   /
	 *      \     |     /                   PhiData
	 *       \    |    /                       |
	 *        \   |   /                       Str
	 *           PhiM
	 *
	 * Is only allowed if the predecessor blocks have only one successor.
	 */

1072
	NEW_ARR_A(ir_node *, projMs, n);
1073
1074
1075
1076
1077
1078
1079
1080
	NEW_ARR_A(ir_node *, inM, n);
	NEW_ARR_A(ir_node *, inD, n);
	NEW_ARR_A(int, idx, n);

	/* Prepare: Collect all Store nodes.  We must do this
	   first because we otherwise may loose a store when exchanging its
	   memory Proj.
	 */
1081
1082
1083
	for (i = n - 1; i >= 0; --i) {
		ir_node *store;

1084
		projMs[i] = get_Phi_pred(phi, i);
1085
		assert(is_Proj(projMs[i]));
1086

1087
1088
		store = get_Proj_pred(projMs[i]);
		info  = get_irn_link(store);
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101

		inM[i] = get_Store_mem(store);
		inD[i] = get_Store_value(store);
		idx[i] = info->exc_idx;
	}
	block = get_nodes_block(phi);

	/* second step: create a new memory Phi */
	phiM = new_rd_Phi(get_irn_dbg_info(phi), current_ir_graph, block, n, inM, mode_M);

	/* third step: create a new data Phi */
	phiD = new_rd_Phi(get_irn_dbg_info(phi), current_ir_graph, block, n, inD, mode);

1102
	/* rewire memory and kill the node */
1103
	for (i = n - 1; i >= 0; --i) {
1104
		ir_node *proj  = projMs[i];
1105

1106
1107
1108
1109
1110
		if(is_Proj(proj)) {
			ir_node *store = get_Proj_pred(proj);
			exchange(proj, inM[i]);
			kill_node(store);
		}
1111
1112
	}

1113
1114
	/* fourth step: create the Store */
	store = new_rd_Store(db, current_ir_graph, block, phiM, ptr, phiD);
1115
#ifdef DO_CACHEOPT
1116
	co_set_irn_name(store, co_get_irn_ident(old_store));
1117
1118
#endif

1119
	projM = new_rd_Proj(NULL, current_ir_graph, block, store, mode_M, pn_Store_M);
1120

1121
1122
	info = get_ldst_info(store, wenv);
	info->projs[pn_Store_M] = projM;
Michael Beck's avatar
Michael Beck committed
1123

1124
1125
1126
	/* fifths step: repair exception flow */
	if (exc) {
		ir_node *projX = new_rd_Proj(NULL, current_ir_graph, block, store, mode_X, pn_Store_X_except);
Michael Beck's avatar
Michael Beck committed
1127

1128
1129
1130
		info->projs[pn_Store_X_except] = projX;
		info->exc_block                = exc;
		info->exc_idx                  = idx[0];
1131

1132
1133
1134
		for (i = 0; i < n; ++i) {
			set_Block_cfgpred(exc, idx[i], projX);
		}
Michael Beck's avatar
Michael Beck committed
1135

1136
1137
1138
		if (n > 1) {
			/* the exception block should be optimized as some inputs are identical now */
		}
1139

1140
1141
		res |= CF_CHANGED;
	}
Michael Beck's avatar
Michael Beck committed
1142

1143
1144
	/* sixth step: replace old Phi */
	exchange(phi, projM);
Michael Beck's avatar
Michael Beck committed
1145

1146
1147
	return res | DF_CHANGED;
}  /* optimize_phi */
Michael Beck's avatar
Michael Beck committed
1148

Michael Beck's avatar
Michael Beck committed
1149
/**
Michael Beck's avatar
Michael Beck committed
1150
 * walker, do the optimizations
Michael Beck's avatar
Michael Beck committed
1151
 */
1152
1153
static void do_load_store_optimize(ir_node *n, void *env) {
	walk_env_t *wenv = env;
Michael Beck's avatar
Michael Beck committed
1154

1155
	switch (get_irn_opcode(n)) {
Michael Beck's avatar
Michael Beck committed
1156

1157
1158
1159
	case iro_Load:
		wenv->changes |= optimize_load(n);
		break;
Michael Beck's avatar
Michael Beck committed
1160

1161
1162
1163
	case iro_Store:
		wenv->changes |= optimize_store(n);
		break;
Michael Beck's avatar
Michael Beck committed
1164

1165
1166
	case iro_Phi:
		wenv->changes |= optimize_phi(n, wenv);
Michael Beck's avatar
Michael Beck committed
1167

1168
1169
	default:
		;
1170
1171
	}
}  /* do_load_store_optimize */
Michael Beck's avatar
Michael Beck committed
1172
1173
1174
1175

/*
 * do the load store optimization
 */
1176
1177
1178
1179
1180
1181
void optimize_load_store(ir_graph *irg) {
	walk_env_t env;

	assert(get_irg_phase_state(irg) != phase_building);
	assert(get_irg_pinned(irg) != op_pin_state_floats &&
		"LoadStore optimization needs pinned graph");
Michael Beck's avatar
Michael Beck committed
1182

1183
1184
	if (! get_opt_redundant_loadstore())
		return;
Michael Beck's avatar
Michael Beck committed
1185

1186
	edges_assure(irg);
Michael Beck's avatar
Michael Beck committed
1187

1188
1189
	/* for Phi optimization post-dominators are needed ... */
	assure_postdoms(irg);
Michael Beck's avatar
BugFix:    
Michael Beck committed
1190

1191
1192
1193
1194
	if (get_opt_alias_analysis()) {
		assure_irg_address_taken_computed(irg);
		assure_irp_globals_address_taken_computed();
	}
1195

1196
1197
	obstack_init(&env.obst);
	env.changes = 0;
Michael Beck's avatar
Michael Beck committed
1198

1199
1200
1201
	/* init the links, then collect Loads/Stores/Proj's in lists */
	master_visited = 0;
	irg_walk_graph(irg, firm_clear_link, collect_nodes, &env);
Michael Beck's avatar
Michael Beck committed
1202

1203
1204
	/* now we have collected enough information, optimize */
	irg_walk_graph(irg, NULL, do_load_store_optimize, &env);
Michael Beck's avatar
Michael Beck committed
1205

1206
	obstack_free(&env.obst, NULL);
Michael Beck's avatar
Michael Beck committed
1207

1208
1209
	/* Handle graph state */
	if (env.changes) {
1210
		set_irg_outs_inconsistent(irg);
1211
	}
Michael Beck's avatar
Michael Beck committed
1212

1213
1214
1215
1216
1217
1218
	if (env.changes & CF_CHANGED) {
		/* is this really needed: Yes, control flow changed, block might
		have Bad() predecessors. */
		set_irg_doms_inconsistent(irg);
	}
}  /* optimize_load_store */