made code C89 compliant (changed unnamed union in attributes)

added default cases for switch
removed some unused variables
code cleanup

ir/be/ppc32/bearch_ppc32.c

@@ -462,10 +462,9 @@ static void ppc32_transform_spill(ir_node *node, void *env)
 
 	if(be_is_Spill(node))
 	{
-		ir_node *store, *proj;
-		dbg_info *dbg = get_irn_dbg_info(node);
-		ir_node *block = get_nodes_block(node);
-		ir_mode *mode = get_irn_mode(node);
+		ir_node  *store, *proj;
+		dbg_info *dbg   = get_irn_dbg_info(node);
+		ir_node  *block = get_nodes_block(node);
 
 		const arch_register_class_t *regclass = arch_get_irn_reg_class(cgenv->arch_env, node, 1);
 
@@ -499,9 +498,9 @@ static void ppc32_transform_spill(ir_node *node, void *env)
 	{
 		ir_node *load, *proj;
 		const arch_register_t *reg;
-		dbg_info *dbg = get_irn_dbg_info(node);
-		ir_node *block = get_nodes_block(node);
-		ir_mode *mode = get_irn_mode(node);
+		dbg_info *dbg   = get_irn_dbg_info(node);
+		ir_node  *block = get_nodes_block(node);
+		ir_mode  *mode  = get_irn_mode(node);
 
 		const arch_register_class_t *regclass = arch_get_irn_reg_class(cgenv->arch_env, node, -1);
 
@@ -584,8 +583,7 @@ int is_direct_entity(entity *ent);
  * @param env     the debug module
  */
 void ppc32_collect_symconsts_walk(ir_node *node, void *env) {
-	ppc32_code_gen_t *cg = env;
-	if(get_irn_op(node)==op_SymConst)
+	if(get_irn_op(node) == op_SymConst)
 	{
 		entity *ent = get_SymConst_entity(node);
 		if(!is_direct_entity(ent))
@@ -741,7 +739,7 @@ static void ppc32_get_call_abi(const void *self, ir_type *method_type, be_abi_ca
 	int		  fpregi = REG_F1;
 
 	const arch_register_t *reg;
-	be_abi_call_flags_t call_flags = { 0, 0, 1, 0, 0, 0, 1 };
+	be_abi_call_flags_t call_flags = { { 0, 0, 1, 0, 0, 0, 1 } };
 
 	if(get_type_visibility(method_type)!=visibility_external_allocated)
 		call_flags.bits.call_has_imm = 1;

ir/be/ppc32/ppc32_emitter.c

@@ -612,15 +612,15 @@ static void ppc32_gen_block(ir_node *block, void *env) {
  * Emits code for function start.
  */
 void ppc32_emit_start(FILE *F, ir_graph *irg, ppc32_emit_env_t *env) {
-	const char *irg_name = get_entity_ld_name(get_irg_entity(irg));
-	int framesize = get_type_size_bytes(get_irg_frame_type(env->cg->irg));
+	const char *irg_name  = get_entity_ld_name(get_irg_entity(irg));
+	int         framesize = get_type_size_bytes(get_irg_frame_type(env->cg->irg));
 
-	if(!strcmp(irg_name, "main"))						   // XXX: underscore hack
+	if(! strcmp(irg_name, "main"))						   // XXX: underscore hack
 	{
 		fprintf(F, "\t.text\n");
-		fprintf(F, "\t.globl _main\n", irg_name);
+		fprintf(F, "\t.globl _main\n");
 		fprintf(F, "\t.align 4\n");
-		fprintf(F, "_main:\n", irg_name);
+		fprintf(F, "_main:\n");
 	}
 	else
 	{
@@ -630,7 +630,7 @@ void ppc32_emit_start(FILE *F, ir_graph *irg, ppc32_emit_env_t *env) {
 		fprintf(F, "%s:\n", irg_name);
 	}
 
-	if(framesize>24)
+	if(framesize > 24)
 	{
 		fprintf(F, "\tmflr    r0\n");
 		fprintf(F, "\tstw     r0, 8(r1)\n");
@@ -638,7 +638,7 @@ void ppc32_emit_start(FILE *F, ir_graph *irg, ppc32_emit_env_t *env) {
 	}
 	else
 	{
-		fprintf(F, "\t\t\t\t\t/* set new frame omitted */\n", framesize);
+		fprintf(F, "\t\t\t\t\t/* set new frame (%d) omitted */\n", framesize);
 	}
 
 
@@ -655,7 +655,6 @@ void ppc32_emit_start(FILE *F, ir_graph *irg, ppc32_emit_env_t *env) {
  * Emits code for function end
  */
 void ppc32_emit_end(FILE *F, ir_graph *irg, ppc32_emit_env_t *env) {
-	const char *irg_name = get_entity_ld_name(get_irg_entity(irg));
 	int framesize = get_type_size_bytes(get_irg_frame_type(env->cg->irg));
 
 /*	if(!isleaf)
@@ -666,7 +665,7 @@ void ppc32_emit_end(FILE *F, ir_graph *irg, ppc32_emit_env_t *env) {
 		fprintf(F, "\taddi    r1, r1, 4\n");
 		fprintf(F, "\tmtlr    r0\n");
 	}*/
-	if(framesize>24)
+	if(framesize > 24)
 	{
 		fprintf(F, "\tlwz     r1, 0(r1)\n");
 		fprintf(F, "\tlwz     r0, 8(r1)\n");

ir/be/ppc32/ppc32_new_nodes.c

@@ -393,7 +393,7 @@ ppc32_attr_content_type get_ppc32_type(const ir_node *node) {
 void set_ppc32_constant_tarval(const ir_node *node, tarval *const_tarval) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
 	attr->content_type = ppc32_ac_Const;
-	attr->constant_tarval = const_tarval;
+	attr->data.constant_tarval = const_tarval;
 }
 
 /**
@@ -401,7 +401,7 @@ void set_ppc32_constant_tarval(const ir_node *node, tarval *const_tarval) {
  */
 tarval *get_ppc32_constant_tarval(const ir_node *node) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
-	return attr->constant_tarval;
+	return attr->data.constant_tarval;
 }
 
 /**
@@ -410,7 +410,7 @@ tarval *get_ppc32_constant_tarval(const ir_node *node) {
 void set_ppc32_symconst_ident(const ir_node *node, ident *symconst_ident) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
 	attr->content_type = ppc32_ac_SymConst;
-	attr->symconst_ident = symconst_ident;
+	attr->data.symconst_ident = symconst_ident;
 }
 
 /**
@@ -418,7 +418,7 @@ void set_ppc32_symconst_ident(const ir_node *node, ident *symconst_ident) {
  */
 ident *get_ppc32_symconst_ident(const ir_node *node) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
-	return attr->symconst_ident;
+	return attr->data.symconst_ident;
 }
 
 
@@ -428,7 +428,7 @@ ident *get_ppc32_symconst_ident(const ir_node *node) {
 void set_ppc32_frame_entity(const ir_node *node, entity *ent) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
 	attr->content_type = ppc32_ac_FrameEntity;
-	attr->frame_entity = ent;
+	attr->data.frame_entity = ent;
 }
 
 /**
@@ -436,7 +436,7 @@ void set_ppc32_frame_entity(const ir_node *node, entity *ent) {
  */
 entity *get_ppc32_frame_entity(const ir_node *node) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
-	return attr->frame_entity;
+	return attr->data.frame_entity;
 }
 
 /**
@@ -445,9 +445,9 @@ entity *get_ppc32_frame_entity(const ir_node *node) {
 void set_ppc32_rlwimi_const(const ir_node *node, unsigned shift, unsigned maskA, unsigned maskB) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
 	attr->content_type = ppc32_ac_RlwimiConst;
-	attr->rlwimi_const.shift = shift;
-	attr->rlwimi_const.maskA = maskA;
-	attr->rlwimi_const.maskB = maskB;
+	attr->data.rlwimi_const.shift = shift;
+	attr->data.rlwimi_const.maskA = maskA;
+	attr->data.rlwimi_const.maskB = maskB;
 }
 
 /**
@@ -455,7 +455,7 @@ void set_ppc32_rlwimi_const(const ir_node *node, unsigned shift, unsigned maskA,
  */
 rlwimi_const_t *get_ppc32_rlwimi_const(const ir_node *node) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
-	return &attr->rlwimi_const;
+	return &attr->data.rlwimi_const;
 }
 
 /**
@@ -464,7 +464,7 @@ rlwimi_const_t *get_ppc32_rlwimi_const(const ir_node *node) {
 void set_ppc32_proj_nr(const ir_node *node, int proj_nr) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
 	attr->content_type = ppc32_ac_BranchProj;
-	attr->proj_nr = proj_nr;
+	attr->data.proj_nr = proj_nr;
 }
 
 /**
@@ -472,7 +472,7 @@ void set_ppc32_proj_nr(const ir_node *node, int proj_nr) {
  */
 int get_ppc32_proj_nr(const ir_node *node) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
-	return attr->proj_nr;
+	return attr->data.proj_nr;
 }
 
 /**
@@ -481,7 +481,7 @@ int get_ppc32_proj_nr(const ir_node *node) {
 void set_ppc32_offset(const ir_node *node, int offset) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
 	attr->content_type = ppc32_ac_Offset;
-	attr->proj_nr = offset;
+	attr->data.offset  = offset;
 }
 
 /**
@@ -489,7 +489,7 @@ void set_ppc32_offset(const ir_node *node, int offset) {
  */
 int get_ppc32_offset(const ir_node *node) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
-	return attr->offset;
+	return attr->data.offset;
 }
 
 /**
@@ -516,20 +516,19 @@ void init_ppc32_attributes(ir_node *node, int flags,
 						 const ppc32_register_req_t **in_reqs, const ppc32_register_req_t **out_reqs, int n_res) {
 	ppc32_attr_t *attr = get_ppc32_attr(node);
 
-	attr->flags = flags;
-	attr->in_req = in_reqs;
+	attr->flags   = flags;
+	attr->in_req  = in_reqs;
 	attr->out_req = out_reqs;
-	attr->n_res = n_res;
-
-	attr->slots = NULL;
+	attr->n_res   = n_res;
+	attr->slots   = NULL;
 
 	if (n_res) {
 		attr->slots = xcalloc(n_res, sizeof(attr->slots[0]));
 	}
 
 	attr->content_type = ppc32_ac_None;
-	attr->offset_mode = ppc32_ao_Illegal;
-	attr->empty = NULL;
+	attr->offset_mode  = ppc32_ao_Illegal;
+	attr->data.empty   = NULL;
 }
 
 /**

ir/be/ppc32/ppc32_nodes_attr.h

@@ -45,7 +45,7 @@ typedef struct _ppc32_attr_t {
 		int proj_nr;
 		int offset;
 		void* empty;
-	};
+	} data;
 
 } ppc32_attr_t;
 

ir/be/ppc32/ppc32_spec.pl

@@ -223,7 +223,7 @@ $comment_string = "/*";
   "emit"      => '. addi    %D1, %S1, %C\t\t\t/* Addi(%S1, %C) -> %D1, (%A1, const) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -363,7 +363,7 @@ $comment_string = "/*";
   "emit"      => '. sraw    %D1, %S1, %C\t\t\t/* Sraw(%S1, %C) -> %D1, (%A1, const) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 
 },
@@ -382,7 +382,7 @@ $comment_string = "/*";
   "emit"      => '. rlwinm  %D1, %S1, %ppc32_rlwimi_emit_helper\t\t\t/* Rlwinm(%S1, %ppc32_rlwimi_emit_helper) -> %D1, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -446,7 +446,7 @@ $comment_string = "/*";
   "reg_req"   => { "out" => [ "general_purpose" ] },
   "cmp_attr"  =>
 '
-	return attr_a->constant_tarval!=attr_b->constant_tarval;
+	return attr_a->data.constant_tarval != attr_b->data.constant_tarval;
 '
 },
 
@@ -457,7 +457,7 @@ $comment_string = "/*";
   "reg_req"   => { "out" => [ "floating_point" ] },
   "cmp_attr"  =>
 '
-	return attr_a->constant_tarval!=attr_b->constant_tarval;
+	return attr_a->data.constant_tarval != attr_b->data.constant_tarval;
 '
 },
 
@@ -468,7 +468,7 @@ $comment_string = "/*";
   "reg_req"   => { "out" => [ "general_purpose" ] },
   "cmp_attr"  =>
 '
-	return attr_a->constant_tarval!=attr_b->constant_tarval;
+	return attr_a->data.constant_tarval != attr_b->data.constant_tarval;
 '
 },
 
@@ -516,7 +516,7 @@ $comment_string = "/*";
   "emit"      => '. addi    %D1, 0, %C\t\t\t/* lower 16 bit of %C (sign extended) -> %D1 */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -526,7 +526,7 @@ $comment_string = "/*";
   "reg_req"   => { "in" => [ "condition" ], "out" => [ "none", "none" ] },
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -542,7 +542,7 @@ $comment_string = "/*";
   "reg_req"   => { "in" => [ "general_purpose", "general_purpose", "condition" ], "out" => [ "none" ] },
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -558,16 +558,16 @@ $comment_string = "/*";
 	attr->offset_mode = om;
 	if (tv) {
 		attr->content_type = ppc32_ac_Const;
-		attr->constant_tarval = tv;
+		attr->data.constant_tarval = tv;
 	}
 	else if (id) {
 		attr->content_type = ppc32_ac_SymConst;
-		attr->symconst_ident = id;
+		attr->data.symconst_ident = id;
 	}
 ',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -579,7 +579,7 @@ $comment_string = "/*";
   "emit"      => '. ori     %D1, %S1, %C\t\t\t/* Ori(%S1,%C) -> %D1 */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -591,7 +591,7 @@ $comment_string = "/*";
   "emit"      => '. andi.   %D1, %S1,%C\t\t\t/* Andi(%S1,%C) -> %D1 (%D2 changed) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -609,7 +609,7 @@ $comment_string = "/*";
   "emit"      => '. cmpi    %D1, 0, %S1, %C\t\t\t/* Cmpi(%S1, %C) -> %D1, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -628,7 +628,7 @@ $comment_string = "/*";
   "emit"      => '. cmpli   %D1, 0, %S1, %C\t\t\t/* Cmpli(%S1, %C) -> %D1, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -644,7 +644,7 @@ $comment_string = "/*";
   "emit"      => '. lbz     %D1, %O(%S1)\t\t\t/* Load(%O(%S1)) -> %D1, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -657,7 +657,7 @@ $comment_string = "/*";
   "emit"      => '. lhz     %D1, %O(%S1)\t\t\t/* Load(%O(%S1)) -> %D1, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -670,7 +670,7 @@ $comment_string = "/*";
   "emit"      => '. lha     %D1, %O(%S1)\t\t\t/* Load(%O(%S1)) -> %D1, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -683,7 +683,7 @@ $comment_string = "/*";
   "emit"      => '. lwz     %D1, %O(%S1)\t\t\t/* Load(%O(%S1)) -> %D1, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -696,7 +696,7 @@ $comment_string = "/*";
   "emit"      => '. lwzu    %D1, %O(%S1)\t\t\t/* Load(%O(%S1)) -> %D1, %S1 += %O, (%A1) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -708,7 +708,7 @@ $comment_string = "/*";
   "emit"      => '. stb     %S2, %O(%S1)\t\t\t/* Store(%S2) -> (%S1), (%A1, %A2) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -720,7 +720,7 @@ $comment_string = "/*";
   "emit"      => '. sth     %S2, %O(%S1)\t\t\t/* Store(%S2) -> (%S1), (%A1, %A2) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -732,7 +732,7 @@ $comment_string = "/*";
   "emit"      => '. stw     %S2, %O(%S1)\t\t\t/* Store(%S2) -> (%S1), (%A1, %A2) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -901,7 +901,7 @@ $comment_string = "/*";
   "emit"      => '. lfd     %D1, %O(%S1)\t\t\t/* Load(%O(%S1)) -> %D1 */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -914,7 +914,7 @@ $comment_string = "/*";
   "emit"      => '. lfs     %D1, %O(%S1)\t\t\t/* Load(%O(%S1)) -> %D1 */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -926,7 +926,7 @@ $comment_string = "/*";
   "emit"      => '. stfd    %S2, %O(%S1)\t\t\t/* Store(%S2) -> (%S1), (%A1, %A2) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 
@@ -938,7 +938,7 @@ $comment_string = "/*";
   "emit"      => '. stfs    %S2, %O(%S1)\t\t\t/* Store(%S2) -> (%S1), (%A1, %A2) */',
   "cmp_attr"  =>
 '
-	return (attr_a->constant_tarval!=attr_b->constant_tarval);
+	return (attr_a->data.constant_tarval != attr_b->data.constant_tarval);
 '
 },
 

ir/be/ppc32/ppc32_transform.c

@@ -838,6 +838,8 @@ static ir_node *gen_Conv(ppc32_transform_env_t *env, ir_node *op) {
 			switch(to_mode)
 			{
 				case irm_D: SKIP;
+				default:
+					break;
 			}
 			break;
 
@@ -846,6 +848,8 @@ static ir_node *gen_Conv(ppc32_transform_env_t *env, ir_node *op) {
 			{
 				case irm_F:
 					return new_rd_ppc32_fRsp(env->dbg, env->irg, env->block, op, env->mode);
+				default:
+					break;
 			}
 			break;
 
@@ -864,6 +868,8 @@ static ir_node *gen_Conv(ppc32_transform_env_t *env, ir_node *op) {
 				case irm_Is:
 				case irm_Iu:
 					SKIP;
+				default:
+					break;
 			}
 			break;
 
@@ -883,6 +889,8 @@ static ir_node *gen_Conv(ppc32_transform_env_t *env, ir_node *op) {
 					return own_gen_Andi_dot_lo16(env, op, 0xff);
 				case irm_Hs:
 					return new_rd_ppc32_Extsh(env->dbg, env->irg, env->block, op, env->mode);
+				default:
+					break;
 			}
 			break;
 
@@ -900,11 +908,15 @@ static ir_node *gen_Conv(ppc32_transform_env_t *env, ir_node *op) {
 					SKIP;
 				case irm_Bs:
 					return new_rd_ppc32_Extsb(env->dbg, env->irg, env->block, op, env->mode);
+				default:
+					break;
 			}
 			break;
 		case irm_P:
 			if(to_mode==irm_Is || to_mode==irm_Iu) SKIP;
 			break;
+		default:
+			break;
 	}
 
 	fprintf(stderr, "Mode for Conv not supported: %s -> %s\n",
@@ -928,14 +940,13 @@ static ir_node *gen_Conv(ppc32_transform_env_t *env, ir_node *op) {
  */
 static ir_node *gen_Abs(ppc32_transform_env_t *env, ir_node *op) {
 	int shift = 7;
+	ir_node *n1,*n2;
+
 	switch(get_nice_modecode(env->mode))
 	{
 		case irm_F:
 		case irm_D:
 			return new_rd_ppc32_fAbs(env->dbg, env->irg, env->block, op, env->mode);
-
-		{
-			ir_node *n1,*n2;
 		case irm_Is:
 			shift += 16;
 		case irm_Hs:
@@ -946,7 +957,8 @@ static ir_node *gen_Abs(ppc32_transform_env_t *env, ir_node *op) {
 			set_ppc32_offset_mode(n1, ppc32_ao_None);
 			n2 = new_rd_ppc32_Add(env->dbg, env->irg, env->block, op, n1, env->mode);
 			return new_rd_ppc32_Xor(env->dbg, env->irg, env->block, n2, n1, env->mode);
-		}
+		default:
+			break;
 	}
 	fprintf(stderr, "Mode for Abs not supported: %s\n", get_mode_name(env->mode));
 	assert(0);
@@ -1492,7 +1504,7 @@ static ir_node *gen_fp_known_symconst(ppc32_transform_env_t *env, tarval *known_
 
 	if(!entry->ent) {
 		char buf[80];
-		sprintf(buf, "const_%i", get_irn_node_nr(env->irn));
+		sprintf(buf, "const_%ld", get_irn_node_nr(env->irn));
 		ent = new_entity(get_glob_type(), new_id_from_str(buf), tp);
 
 		set_entity_ld_ident(ent, get_entity_ident(ent));
@@ -1511,7 +1523,7 @@ static ir_node *gen_fp_known_symconst(ppc32_transform_env_t *env, tarval *known_
 
 		/* set the entry for hashmap */
 		entry->ent = ent;
-	}									   // TODO: Wird nicht richtig in global type gesteckt, ppc32_gen_decls.c findet ihn nicht
+	}				 // TODO: Wird nicht richtig in global type gesteckt, ppc32_gen_decls.c findet ihn nicht
 
 	symcnst = new_rd_ppc32_SymConst(env->dbg, env->irg, env->block, env->mode);
 	set_ppc32_frame_entity(symcnst, ent);
@@ -1723,24 +1735,23 @@ static ir_node *gen_ppc32_SymConst(ppc32_transform_env_t *env) {
  * @param env     the debug module
  */
 void ppc32_transform_const(ir_node *node, void *env) {
-	ppc32_code_gen_t *cgenv = (ppc32_code_gen_t *)env;
-	opcode  code               = get_irn_opcode(node);
-	ir_node *asm_node          = NULL;
+	ppc32_code_gen_t *cgenv    = (ppc32_code_gen_t *)env;
+	ir_node          *asm_node = NULL;
 	ppc32_transform_env_t tenv;
 
 	if (is_Block(node))
 		return;
 
-	tenv.block    = get_nodes_block(node);
-	tenv.dbg      = get_irn_dbg_info(node);
-	tenv.irg      = current_ir_graph;
-	tenv.irn      = node;
-	tenv.mod      = cgenv->mod;
-	tenv.mode     = get_irn_mode(node);
+	tenv.block = get_nodes_block(node);
+	tenv.dbg   = get_irn_dbg_info(node);
+	tenv.irg   = current_ir_graph;
+	tenv.irn   = node;
+	tenv.mod   = cgenv->mod;
+	tenv.mode  = get_irn_mode(node);
 
-#define OTHER_GEN(a)                                                       \
-	if (get_irn_op(node) == get_op_##a()) {                                \
-		asm_node = gen_##a(&tenv);                                         \
+#define OTHER_GEN(a)                        \
+	if (get_irn_op(node) == get_op_##a()) { \
+		asm_node = gen_##a(&tenv);          \
 	}
 
 	DBG((tenv.mod, LEVEL_1, "check %+F ... ", node));
@@ -1756,4 +1767,5 @@ void ppc32_transform_const(ir_node *node, void *env) {
 	else {
 		DB((tenv.mod, LEVEL_1, "ignored\n"));
 	}
+#undef OTHER_GEN
 }