Commit be6cf61e authored by Christoph Mallon's avatar Christoph Mallon
Browse files

- Remove stale comment.

- Do not generate dest am for 8bit operations, because the stricter register constraints are not handled yet.

[r15787]
parent 2e427571
...@@ -482,12 +482,6 @@ static int use_source_address_mode(ir_node *block, ir_node *node, ...@@ -482,12 +482,6 @@ static int use_source_address_mode(ir_node *block, ir_node *node,
mode = get_irn_mode(node); mode = get_irn_mode(node);
if(!mode_needs_gp_reg(mode)) if(!mode_needs_gp_reg(mode))
return 0; return 0;
/*
* Matze: the unresolved question here is wether 8/16bit operations
* are a good idea if they define registers (as writing to an 8/16
* bit reg is bad on modern cpu as it confuses the dependency calculation
* for the full reg)
*/
if(other != NULL && get_Load_mode(load) != get_irn_mode(other)) if(other != NULL && get_Load_mode(load) != get_irn_mode(other))
return 0; return 0;
...@@ -1776,6 +1770,10 @@ static ir_node *try_create_dest_am(ir_node *node) { ...@@ -1776,6 +1770,10 @@ static ir_node *try_create_dest_am(ir_node *node) {
if(!mode_needs_gp_reg(mode)) if(!mode_needs_gp_reg(mode))
return NULL; return NULL;
/* TODO0000 8bit operations have stricter constraints. This is not handled yet */
if (get_mode_size_bits(mode) < 16)
return NULL;
/* store must be the only user of the val node */ /* store must be the only user of the val node */
if(get_irn_n_edges(val) > 1) if(get_irn_n_edges(val) > 1)
return NULL; return NULL;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment