GitLab

Consider a function with frame pointer relative addressing, where the only users of the stack are the Returns.
Still space for values might be allocated on the stack.
To prevent this, during prologue construction the IncSP was kept, if it had at most one user.
If there are multiple returns, then there was more than one user, so the IncSP is not kept.
Then during epilogue construction these uses are replaced by movl %ebp, %esp/leave.
This renders the allocation of the frame unused and it vanishes.
So memory below the stack pointer is accessed.

Now first construct the epilogues.
Then, when the prologue is constructed afterwards, we know whether the IncSP is unused and needs to be kept.

Still this is a hack.
The correct solution would be, that IncSP produces memory, so memory operations accessing stack slots use this memory.

It pops a value from the stack, so this memory access should be represented in the graph.

* No \n at end; panic() adds one
* No punctuation mark at end
* Lowercase first letter

The operands were swapped.

It was only used in an assertion.

The variable was initialised to this just a few lines above.

* It was retrieved from the arch_env before.
* Also rename be_abi_fix_stack_nodes() to be_fix_stack_nodes().

be: Remove the unused thin wrapper macros arch_register_class_index() and arch_register_class_name().

All other structs holding a register class call it cls, too.

ia32: Remove redundant calls to clear_ia32_use_frame()/set_ia32_use_frame() just after/before set_ia32_frame_ent().

It was just done before a few lines above.

ia32: Directly put the bitfields in ia32_attr_t instead of having another struct needlessly wrapping them.